From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Nicole Edwards <nnnnnn@posteo.net>
Cc: 22438@debbugs.gnu.org
Subject: bug#22438: 24.5; Orphaned tooltip kills daemon (Lucid)
Date: Sat, 23 Jan 2016 00:56:03 +0100 [thread overview]
Message-ID: <87d1stkw30.fsf@wanadoo.es> (raw)
In-Reply-To: <d31a7f1ac3fe8244b415c4e430fab34d@posteo.net> (Nicole Edwards's message of "Fri, 22 Jan 2016 17:04:36 -0500")
Nicole Edwards <nnnnnn@posteo.net> writes:
> If I call up (or dismiss all but) one frame, ask it to display
> a tooltip, then destroy it while the tooltip is open, the tooltip
> remains open, and unless I create a new frame within a few seconds,
> Emacs dies. (Mercifully, so does the tooltip.)
[snip]
The problem is in src/xfns.c:6087. Emacs explicitly redisplays the
current frame's menu bar without testing that it is alive. The patch
below solves the problem. Eli, ok to commit?
diff --git a/src/xfns.c b/src/xfns.c
index aad9680..9624ac5 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -6084,16 +6084,19 @@ Value is t if tooltip was open, nil otherwise. */)
items is unmapped. Redisplay the menu manually... */
{
Widget w;
- struct frame *f = SELECTED_FRAME ();
- w = f->output_data.x->menubar_widget;
+ struct frame *f = SELECTED_FRAME ();
+ if (FRAME_X_P (f) && FRAME_LIVE_P (f))
+ {
+ w = f->output_data.x->menubar_widget;
- if (!DoesSaveUnders (FRAME_DISPLAY_INFO (f)->screen)
- && w != NULL)
- {
- block_input ();
- xlwmenu_redisplay (w);
- unblock_input ();
- }
+ if (!DoesSaveUnders (FRAME_DISPLAY_INFO (f)->screen)
+ && w != NULL)
+ {
+ block_input ();
+ xlwmenu_redisplay (w);
+ unblock_input ();
+ }
+ }
}
#endif /* USE_LUCID */
}
next prev parent reply other threads:[~2016-01-22 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 22:04 bug#22438: 24.5; Orphaned tooltip kills daemon (Lucid) Nicole Edwards
2016-01-22 23:56 ` Óscar Fuentes [this message]
2016-01-23 6:14 ` Eli Zaretskii
2016-01-23 13:22 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1stkw30.fsf@wanadoo.es \
--to=ofv@wanadoo.es \
--cc=22438@debbugs.gnu.org \
--cc=nnnnnn@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).