From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4048: 23.1; erc-server-reconnect-attempts does not work Date: Thu, 04 Feb 2016 18:11:51 +1100 Message-ID: <87d1sdymo8.fsf@gnus.org> References: <878u4f4ixq.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454570003 16654 80.91.229.3 (4 Feb 2016 07:13:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2016 07:13:23 +0000 (UTC) Cc: Andreas Schwab , 4048@debbugs.gnu.org To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 08:13:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRE6K-0006sI-4e for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 08:13:12 +0100 Original-Received: from localhost ([::1]:40007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRE6J-00045b-Da for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 02:13:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRE6D-00044j-LK for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 02:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRE6A-000494-0v for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 02:13:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRE69-00048j-Tl for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 02:13:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aRE69-00025D-Ku for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 02:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 07:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 4048-submit@debbugs.gnu.org id=B4048.14545699487953 (code B ref 4048); Thu, 04 Feb 2016 07:13:01 +0000 Original-Received: (at 4048) by debbugs.gnu.org; 4 Feb 2016 07:12:28 +0000 Original-Received: from localhost ([127.0.0.1]:58865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRE5a-00024B-8n for submit@debbugs.gnu.org; Thu, 04 Feb 2016 02:12:28 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38877) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRE5V-00023y-QU for 4048@debbugs.gnu.org; Thu, 04 Feb 2016 02:12:25 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRE56-0001MV-9Y; Thu, 04 Feb 2016 08:11:56 +0100 In-Reply-To: <878u4f4ixq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 27 Dec 2015 23:37:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) X-MailScanner-ID: 1aRE56-0001MV-9Y MailScanner-NULL-Check: 1455174717.01459@Putbq8xcUL4cox/OjkseBg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112395 Archived-At: Lars Ingebrigtsen writes: > Vivek Dasmohapatra writes: > >> Does this patch make the problem go away? It seems to work here. >> >> The problem was that erc-mode was killing all local variables, even when >> the mode was already erc-mode : The patch makes it preserve the >> reconnection count in that case, which seems to have the desired effect >> without adversely affecting anything else. >> >> [ Stomping on the route didn't work for me as the existing connection was >> grandfathered in by the kernel: Installing a local ircd and shutting it >> down behind the client's back worked nicely though. ] > > IThis patch no longer applies: > > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -1445,7 +1445,10 @@ Special commands: > \\{erc-mode-map} > > Turning on `erc-mode' runs the hook `erc-mode-hook'." > - (kill-all-local-variables) > + (let ((recon-count erc-server-reconnect-count) (old-mode major-mode)) > + (kill-all-local-variables) > + (if (and (eq old-mode 'erc-mode) (integerp recon-count) (< 0 recon-count)) > + (setq erc-server-reconnect-count recon-count))) > (use-local-map erc-mode-map) > (setq mode-name "ERC" > major-mode 'erc-mode > > Is this still a problem in erc in Emacs 25? More information was requested, but no response was given within a month, so I'm closing this bug report. If the problem still exists, please reopen this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no