From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Gamari Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Sun, 07 Feb 2016 11:22:08 +0100 Message-ID: <87d1s8akhb.fsf@smart-cactus.org> References: <87wpvebraz.fsf@smart-cactus.org> <87oabu9fwh.fsf@smart-cactus.org> <87zivd8fra.fsf@gmail.com> <87vb613ye0.fsf@gmail.com> <877fih3xk1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1454840603 8245 80.91.229.3 (7 Feb 2016 10:23:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Feb 2016 10:23:23 +0000 (UTC) Cc: 21559@debbugs.gnu.org To: Mitchel Humpherys Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 07 11:23:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSMUn-0007gh-Tm for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 11:23:10 +0100 Original-Received: from localhost ([::1]:33064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSMUm-0007eY-U1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 05:23:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSMUj-0007dp-8N for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 05:23:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSMUg-0005hM-1u for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 05:23:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSMUf-0005gu-Rf for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 05:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aSMUf-0005IX-LR for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 05:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ben Gamari Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 10:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.145484055720332 (code B ref 21559); Sun, 07 Feb 2016 10:23:01 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 7 Feb 2016 10:22:37 +0000 Original-Received: from localhost ([127.0.0.1]:36470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSMUH-0005Hs-M0 for submit@debbugs.gnu.org; Sun, 07 Feb 2016 05:22:37 -0500 Original-Received: from mail.smart-cactus.org ([54.187.36.80]:45629) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSMUG-0005Hg-Jd for 21559@debbugs.gnu.org; Sun, 07 Feb 2016 05:22:36 -0500 Original-Received: from localhost.localdomain (HSI-KBW-149-172-43-78.hsi13.kabel-badenwuerttemberg.de [149.172.43.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: ben@smart-cactus.org) by mail.smart-cactus.org (Postfix) with ESMTPSA id 534D340516; Sun, 7 Feb 2016 10:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.smart-cactus.org; s=mail; t=1454839713; bh=4GbxD45VhCL38sw2oKATLhTaFRVethW9oLOEK1IiBRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TBgzZqzjxV9W5vSUvR/QKMen3SDbeMAEAdPL8vy7eCHmN/ASbLgijDAFFrxeX6adu t+OHI8DmM0Ppf2sOwIAEgDNM24OZ1DJwxOShnb9iP0vG/2Uaap0A2WAzg27xxNZLQL 37YmAQlkOb5Xm4kbmPOZ+WEthJy4jKsnNBpouei0= In-Reply-To: <877fih3xk1.fsf@gmail.com> User-Agent: Notmuch/0.21+24~gbceb651 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112616 Archived-At: --=-=-= Content-Type: text/plain Mitchel Humpherys writes: > So we're back to instrumenting vc{,-git}.el to see exactly which git > commands are being run when auto-revert refreshes a buffer. I recently revisited this and came up with this hack (after realizing that my previous tracing approach was badly broken), (defun my-tracing-function (orig &rest args) (message "call-process %s" args)) (advice-add 'call-process :before #'my-tracing-function) (message "installed") This produces, call-process (nil (t nil) nil ls-files -c -z -- COPYING) call-process (nil (t nil) nil rev-parse HEAD) call-process (nil (t nil) nil symbolic-ref HEAD) call-process (nil (t nil) nil diff-index -p --raw -z HEAD -- COPYING) call-process (nil (t nil) nil status --porcelain -- COPYING) call-process (nil (t nil) nil ls-files -c -z -- COPYING) call-process (nil (t nil) nil rev-parse HEAD) call-process (nil (t nil) nil symbolic-ref HEAD) call-process (nil (t nil) nil diff-index -p --raw -z HEAD -- COPYING) call-process (nil (t nil) nil status --porcelain -- COPYING) Quit call-process (nil (t nil) nil ls-files -c -z -- COPYING) After stracing each of these I've found that status --porcelain indeed takes index.lock. Unfortunately I can't find a good explanation of why this is necessary. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWtxrQAAoJEHPt6ejPuu8BbYYIALWE7aHsJBJcCMq/GicVWvcu nMDyHiKmd384wSE7gGYL02AE9r+Dc2ClGvcGA1Lpr3vJOEyrST/zhRWrW+1GVJIV PEpfQ4uxsGTGaMuzE39AmTt1BlCusT5wbSebd0hn96r0KXN5JnYmePRu0YR6da6N WVhDpQ4apkavEK6+W0zdeEMol4ktUJQ2or15lLhk6zcBht/lN0Mi+ewFuXdZ9SgP wH87sbjfBhpykNoqX/krCWTO10Rpn9T/1nF0OeTcKlt91oICVFLyKnly4lZaEgVv r3iM5eWg7KIn8PHDZl+6STEr9mAqpC0HQ5ZUCHk5sp875dzsmRU0Q5GuR8A/bBg= =F7tQ -----END PGP SIGNATURE----- --=-=-=--