From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tassilo Horn <tsdh@gnu.org>, 22736@debbugs.gnu.org
Subject: bug#22736: 25.0.91; file-notify calls wrong callbacks
Date: Fri, 19 Feb 2016 09:46:55 +0100 [thread overview]
Message-ID: <87d1rt5bpc.fsf@gmx.de> (raw)
In-Reply-To: <83a8mxu6fl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Feb 2016 22:09:18 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> The problem is that when there is a directory watch on some directory
>> and a file watch on a file in that directory, the callback for the
>> directory watch gets an event with the descriptor of the file watch.
>
> I think this is because when you ask to watch a file, we actually
> watch its parent directory.
Although we watch the parent directory internally (except with kqueue),
the given scenario by Tassilo shall work as he expected. There shall be
two file notification events in the given case, calling
magit-filenotify--callback and auto-revert-notify-handler with the
respective descriptor.
I'll check.
Tassilo, would you be willing to write an ert test case for the problem?
Best regards, Michael.
next prev parent reply other threads:[~2016-02-19 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 19:04 bug#22736: 25.0.91; file-notify calls wrong callbacks Tassilo Horn
2016-02-18 20:09 ` Eli Zaretskii
2016-02-19 8:46 ` Michael Albinus [this message]
2016-02-19 22:59 ` Tassilo Horn
2016-02-20 13:23 ` Michael Albinus
2016-02-21 8:02 ` Tassilo Horn
2016-02-21 9:01 ` Michael Albinus
2016-02-21 16:02 ` Tassilo Horn
2016-02-22 17:58 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1rt5bpc.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=22736@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).