From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#22968: 25.0.92; ChangeLog to *vc-log* Date: Wed, 09 Mar 2016 23:58:32 +0100 Message-ID: <87d1r3z2i6.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457564364 19179 80.91.229.3 (9 Mar 2016 22:59:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Mar 2016 22:59:24 +0000 (UTC) To: 22968@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 09 23:59:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adn4P-00024K-U0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Mar 2016 23:59:10 +0100 Original-Received: from localhost ([::1]:44952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn4P-0002pI-BA for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Mar 2016 17:59:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn4L-0002pB-VS for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adn4I-0003KQ-Nq for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:59:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn4I-0003KJ-KK for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adn4I-0005q3-Cx for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Mar 2016 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22968 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145756432922420 (code B ref -1); Wed, 09 Mar 2016 22:59:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Mar 2016 22:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:41967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adn45-0005pY-BK for submit@debbugs.gnu.org; Wed, 09 Mar 2016 17:58:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39217) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adn42-0005pK-WF for submit@debbugs.gnu.org; Wed, 09 Mar 2016 17:58:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adn3w-0003Fx-Sf for submit@debbugs.gnu.org; Wed, 09 Mar 2016 17:58:41 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn3w-0003Ft-PB for submit@debbugs.gnu.org; Wed, 09 Mar 2016 17:58:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn3v-0002oS-L0 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:58:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adn3s-0003Fd-E4 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:58:39 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:61178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adn3s-0003FZ-45 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 17:58:36 -0500 Original-Received: from rosalinde ([89.245.66.173]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lkiqm-1a5Yhq11dM-00aSSQ for ; Wed, 09 Mar 2016 23:58:34 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-Provags-ID: V03:K0:FNsOpVgM0dP8CTp5rNNnyhM+YY1nan2LrolA/gph1XuI7TNLnkt sYPuEMerEMRbs7NYmpaO4iBZRZxz7oM0lSU5+fP8Pfl8EKv6PPeTEuEcfmWxDpdUYTZseLO A0QJHChCbV1aaxnwZI6JRSYeGuB46My85JKnKREbrDyWGww/ayqJY+vRmgEd0vhlTTAqaD9 8kj9tUGMz/Tmy4WFr5yPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:nGBC+mQI8Zo=:s0AbGmEWBUy6Qxf1ChfXZu aui9Ugb/vj7mMbss7Ie46wmTW5hapo6sMVmWV6uNmaVjC8rDeG6Nv5nWJ/F0fa7TL7f8tZLoF BXsZnfXBtONPn4B9NcsL6LmaUsUulMtWlibX6R4nwaHidLab7uysNeMjcUaZiCdhiMJfVdA0t Hohfmq6lvKoLtn+4XNZsnbsaaLa+T1lz6tpQRdic257hA3eHavEF/2f3lU1JqGo1zeUDc0dau hQywaRj5FgSzYigVBW5ifK5eWzoNiYPp2Rv/PLlqscrDP/GTvp6x6Gw7GxkXqHbmxl/S1aXbM VXLftEeJBXS+Civt1IiHLsKI+8ld8tcCD+0C8MkuOV9JMXs3sFCnLuOn+P9fBltagIUfzaq/z J7XIyGjKsYcOP9Up0Zygp9d8B+5xZp37cy371hiJ/hmEKkFe7aEWNEPPiQ3tDCYjxo3n5vXtZ u88SxeX4RBbIqylGTay7Si+CKSgIkp8T5rRn5WmCcNnVlCZ/hWhRpmHAqegnZfxOJSWRjt1b6 z3kYEfZVAPqIcI/x795MAU1Rv+6cbgSRurVQ9EADXWrMs1n1lHLYHgeXle6MNzJItWC8RZgaH Cu8cdndJKXAPqEh+3uSBRJIpbJfih0S3J+WbfNmpCVUmw4nYVvvg//WW8o6ahMm2PAPhxbuTC dU9mANLi9w20Lq5xYySTGE95+SszMN7TSGWwBmIO82/cqriBXC05L7rSnhq9c80ovPYlL/LZO 2JNgqtsLbFP1NlUSSuqRas4/ER64zfurONMfE+WWgrxaVSh7Wh0GQDFedSInukGUhKFmI5R9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114673 Archived-At: 0. emacs -Q 1. Edit an Emacs source file, e.g. lisp/calendar/todo-mode.el 2. Type `C-x 4 a' to make a ChangeLog entry (note the ChangeLog buffer is in lisp/calendar/). 3. Type `C-x v d' to get a *vc-dir* buffer, then type `v' to get a *vc-log* buffer. => The ChangeLog entry is not automatically added to the log buffer, and typing `C-c C-a' (log-edit-insert-changelog) in the log buffer also fails to add the ChangeLog entry. Note that if, in step 3, you move point to the line listing the edited file and then type `v', then the log buffer does contain the ChangeLog entry (without, however, the containing directories lisp/calendar/, contravening the current commit message format specification). But if memory serves, this used to work even with point at bob (though I currently cannot easily test this with an earlier version to check my memory). In fact, it still does work if, at step 2, you add a prefix argument, i.e. type `C-u C-x 4 a', and at the prompt enter the top level directory emacs/ as the location of the ChangeLog buffer: then at step 3 typing `v' even at bob does automatically add the ChangeLog entry to the log buffer (and this time the entry does include the containing directories). I haven't debugged why the automatic insertion of the ChangeLog entry into the log buffer fails (as well as `C-c C-a'), but it appears to have to do with the location of the ChangeLog buffer, and this has changed from earlier versions, due to the elimination of files named "ChangeLog" from the Emacs sources (there are now only files named "ChangeLog."). In consequence, find-change-log creates an empty file named "ChangeLog" in the immediate directory of the file in which `C-x 4 a' was invoked, e.g. in lisp/calendar/, when editing todo-mode.el; previously, `C-x 4 a' found lisp/ChangeLog. Strictly speaking, this isn't a bug, since find-change-log is doing what it's designed to do. Nevertheless, if Emacs development does not return to maintaining versioned ChangeLog files, I think it would be desirable for `C-x 4 a' to always create (or find) the file "ChangeLog" at top level when editing Emacs sources, since this would add the containing directories to the commit message. Since other projects that could use `C-x 4 a' may have different requirements on its effect, this should be conditioned by a user option (or maybe just a plain variable), which can (and probably should) be set in .dir-locals.el. There are, of course, alternatives that don't require changing Emacs: e.g. people could just always use `C-u C-x 4 a' or they could just keep an unversioned file "ChangeLog" at top level. But both of these are not as convenient or user-friendly as just typing `C-x 4 a' and having it do the right thing. In GNU Emacs 25.0.92.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-03-09 built on rosalinde Repository revision: 711ca362e7f8ca7c4f664dc2fe60bc5fa4e4f4fe Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3''