unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: "N. Jackson" <nljlistbox2@gmail.com>, 23092-done@debbugs.gnu.org
Subject: bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command
Date: Fri, 25 Mar 2016 00:14:41 +0200	[thread overview]
Message-ID: <87d1qj8qwe.fsf@mail.linkov.net> (raw)
In-Reply-To: <56F39A89.5010608@gmx.at> (martin rudalics's message of "Thu, 24 Mar 2016 08:43:05 +0100")

>> However, after I looked at this again now, it looks natural to just
>> replace ‘shrink-window-if-larger-than-buffer’ with ‘fit-window-to-buffer’.
>> But I'd leave it to you to decide how good this change is and what
>> consequences it might entail.
>
> It should have two consequences: (1) When there are many completions,
> the *Completions* window might be larger initially.

This doesn't look like a bad consequence since more currently active data
on screen is better.

> (2) The *Completions* window will mostly behave as if ‘temp-buffer-resize-mode’
> were enabled by default.  I think the OP's scenario is much more
> embarrassing so I think we can live with the consequences of your fix.
>
> Please install it and I'll fix the manual accordingly.

Fixed minibuffer-completion-help now.

> Thanks, martin
>
>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>> index ecac0ae..6540059 100644
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -1835,7 +1835,7 @@ minibuffer-completion-help
>>                   'display-buffer-below-selected))
>>   	    ,(if temp-buffer-resize-mode
>>   		 '(window-height . resize-temp-buffer-window)
>> -	       '(window-height . shrink-window-if-larger-than-buffer))
>> +	       '(window-height . fit-window-to-buffer))
>>   	    ,(when temp-buffer-resize-mode
>>   	       '(preserve-size . (nil . t))))
>>             nil





  reply	other threads:[~2016-03-24 22:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 17:07 bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command N. Jackson
2016-03-22 17:21 ` martin rudalics
2016-03-22 18:42   ` N. Jackson
2016-03-22 18:53     ` martin rudalics
2016-03-22 19:56       ` N. Jackson
2016-03-22 20:10         ` Eli Zaretskii
2016-03-22 21:06           ` N. Jackson
2016-03-22 18:28 ` Eli Zaretskii
2016-03-22 18:55   ` N. Jackson
2016-03-22 19:04     ` Eli Zaretskii
2016-03-22 20:07       ` N. Jackson
2016-03-23  8:09       ` martin rudalics
2016-03-23 16:45         ` N. Jackson
2016-03-23 18:53           ` martin rudalics
2016-03-23 20:34             ` N. Jackson
2016-03-23 21:27             ` Juri Linkov
2016-03-24  7:43               ` martin rudalics
2016-03-24 22:14                 ` Juri Linkov [this message]
2016-03-25  7:42                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1qj8qwe.fsf@mail.linkov.net \
    --to=juri@jurta.org \
    --cc=23092-done@debbugs.gnu.org \
    --cc=nljlistbox2@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).