From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#15906: 24.3.50; Rename `highlight-*' functions Date: Fri, 29 Apr 2016 16:08:30 +0200 Message-ID: <87d1p87bj5.fsf@gnus.org> References: <24a86bb5-f82f-4211-b0a7-dc40ddd60470@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461938988 22047 80.91.229.3 (29 Apr 2016 14:09:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 14:09:48 +0000 (UTC) Cc: 15906@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 16:09:36 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aw96q-00059g-OE for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 16:09:32 +0200 Original-Received: from localhost ([::1]:54753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw96m-0000aD-Qn for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 10:09:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw96b-0000JE-Tm for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:09:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw96P-00062y-P9 for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:09:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw96P-000628-Mr for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:09:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aw96M-0008Jl-CM for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15906 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15906-submit@debbugs.gnu.org id=B15906.146193891931927 (code B ref 15906); Fri, 29 Apr 2016 14:09:02 +0000 Original-Received: (at 15906) by debbugs.gnu.org; 29 Apr 2016 14:08:39 +0000 Original-Received: from localhost ([127.0.0.1]:55349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw95z-0008It-2N for submit@debbugs.gnu.org; Fri, 29 Apr 2016 10:08:39 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:56033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw95x-0008Il-7J for 15906@debbugs.gnu.org; Fri, 29 Apr 2016 10:08:37 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1aw95q-0000yW-O9; Fri, 29 Apr 2016 16:08:36 +0200 In-Reply-To: <24a86bb5-f82f-4211-b0a7-dc40ddd60470@default> (Drew Adams's message of "Fri, 15 Nov 2013 10:31:24 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117177 Archived-At: Drew Adams writes: > The prefix `highlight-' should not be used for something as specific as > `hi-lock' highlighting or highlighting to show changes. There are lots > of different kinds of highlighting in Emacs. And third party libraries > provide many more ways. The latter are requested by convention to use a > library prefix. > > Hi Lock is one kind of highlighting, and quite particular. The "lock" > part of its name is significant - it differentiates this highlighting > from other highlighting, and it should be present in the function names. > > These are the functions to rename, with suggested renamings: > > highlight-lines-matching-regexp -> hi-lock-lines-matching-regexp > highlight-phrase -> hi-lock-phrase > highlight-regexp -> hi-lock-regexp > highlight-changes-mode -> hilit-changes-mode > highlight-changes-next-change -> hilit-changes-next-change > highlight-changes-previous-change -> hilit-changes-previous-change > highlight-changes-remove-highlight -> hilit-changes-remove-highlight > highlight-changes-rotate-faces -> hilit-changes-rotate-faces > highlight-changes-visible-mode -> hilit-changes-visible-mode > highlight-compare-buffers -> hilit-compare-buffers > highlight-compare-with-file -> hilit-compare-with-file It is perhaps unfortunate that hi-lock has taken these prefixes, but changing this at this point would be too much churn for little gain. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no