unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format'
@ 2014-12-21 17:23 Drew Adams
  2014-12-21 19:02 ` Dmitry Gutov
  2016-04-30 16:31 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 4+ messages in thread
From: Drew Adams @ 2014-12-21 17:23 UTC (permalink / raw)
  To: 19424

This is the warning:

    Warning: `default-mode-line-format' is an obsolete variable
    (as of Emacs 23.2); use `mode-line-format' instead.

That is incorrect and useless.  Clearly, you cannot use
`mode-line-format' in place of `default-mode-line-format'.

The warning should instead say something like this, based on the doc
string:

    Warning: `default-mode-line-format' is an obsolete variable
    (as of Emacs 23.2); use `(default-value 'mode-line-format)' instead.


In GNU Emacs 23.4.1 (i386-mingw-nt6.1.7601)
 of 2012-02-04 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --with-gcc (4.4) --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include'





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format'
  2014-12-21 17:23 bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format' Drew Adams
@ 2014-12-21 19:02 ` Dmitry Gutov
  2014-12-21 20:38   ` Drew Adams
  2016-04-30 16:31 ` Lars Ingebrigtsen
  1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2014-12-21 19:02 UTC (permalink / raw)
  To: Drew Adams; +Cc: 19424

Drew Adams <drew.adams@oracle.com> writes:

>     Warning: `default-mode-line-format' is an obsolete variable
>     (as of Emacs 23.2); use `(default-value 'mode-line-format)' instead.

Why `default-value', but not `setq-default'?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format'
  2014-12-21 19:02 ` Dmitry Gutov
@ 2014-12-21 20:38   ` Drew Adams
  0 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2014-12-21 20:38 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 19424

> >     Warning: `default-mode-line-format' is an obsolete variable
> >     (as of Emacs 23.2); use `(default-value 'mode-line-format)'
> >     instead.
> 
> Why `default-value', but not `setq-default'?

Should be obvious: Because the intention of a given occurrence
of `default-mode-line-format' might not be to set the default
value of `mode-line-format'.

Consider code that used, for example:

(setq mode-line-format  default-mode-line-format)

A reasonable update of that code would likely be

(setq mode-line-format  (default-value 'mode-line-format))

That does not set the default value of `mode-line-format'.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format'
  2014-12-21 17:23 bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format' Drew Adams
  2014-12-21 19:02 ` Dmitry Gutov
@ 2016-04-30 16:31 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-30 16:31 UTC (permalink / raw)
  To: Drew Adams; +Cc: 19424

Drew Adams <drew.adams@oracle.com> writes:

> This is the warning:
>
>     Warning: `default-mode-line-format' is an obsolete variable
>     (as of Emacs 23.2); use `mode-line-format' instead.
>
> That is incorrect and useless.  Clearly, you cannot use
> `mode-line-format' in place of `default-mode-line-format'.
>
> The warning should instead say something like this, based on the doc
> string:
>
>     Warning: `default-mode-line-format' is an obsolete variable
>     (as of Emacs 23.2); use `(default-value 'mode-line-format)' instead.

Now fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-30 16:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-21 17:23 bug#19424: 23.4; incorrect byte-compiler warning for `mode-line-format' Drew Adams
2014-12-21 19:02 ` Dmitry Gutov
2014-12-21 20:38   ` Drew Adams
2016-04-30 16:31 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).