From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git Date: Fri, 17 Jun 2016 16:09:53 +0100 Message-ID: <87d1nf26ny.fsf@russet.org.uk> References: <87a8ioyq9o.fsf@russet.org.uk> <87wplr1z4z.fsf@russet.org.uk> <91e61a46-b3bb-c4d9-cb30-bbfa90135d69@yandex.ru> <877fdqkwki.fsf@russet.org.uk> <9856a1e4-be41-d781-bfbd-22bac360d18b@yandex.ru> <871t3y85oz.fsf@russet.org.uk> <6b6f147e-3b42-ccf5-92fd-0890d6942d4b@yandex.ru> <87vb19zilb.fsf@russet.org.uk> <36d92078-759f-94bd-d381-20d7727c9c85@yandex.ru> <7fc2c908-fbb2-0870-2370-9e340acccc1c@yandex.ru> <87oa70lsap.fsf@russet.org.uk> <9f2cdad5-2ca8-0956-3f60-05cf30012e17@yandex.ru> <87y464bwna.fsf@russet.org.uk> <87twgsbvsc.fsf@russet.org.uk> <55d7d4f1-321c-96a2-63da-8759bebffb89@yandex.ru> <83bn30cnjy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466178970 28127 80.91.229.3 (17 Jun 2016 15:56:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 15:56:10 +0000 (UTC) Cc: 23769@debbugs.gnu.org, Noam Postavsky To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 17:55:58 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDw7e-0007Ze-1i for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 17:55:54 +0200 Original-Received: from localhost ([::1]:58588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDw7d-0006kV-Aa for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 11:55:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDvQI-0001rY-Cl for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 11:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDvQE-0006I6-42 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 11:11:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDvQE-0006Ht-1k for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 11:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDvQD-0007ml-U1 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 11:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23769-submit@debbugs.gnu.org id=B23769.146617620329850 (code B ref 23769); Fri, 17 Jun 2016 15:11:01 +0000 Original-Received: (at 23769) by debbugs.gnu.org; 17 Jun 2016 15:10:03 +0000 Original-Received: from localhost ([127.0.0.1]:44413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDvPG-0007lL-PL for submit@debbugs.gnu.org; Fri, 17 Jun 2016 11:10:03 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:60556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDvPE-0007kq-HI for 23769@debbugs.gnu.org; Fri, 17 Jun 2016 11:10:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=Ruedz1qMFDiOjK8zw9iiLVZEay/POwdK/n7+7QSkxIU=; b=WeXb+VqhUH/WXaA1BDYqGp6yft zhc+9FroVoLtyV7h9vwVTXdSnoY0j1HgOATPlT+n1XE3nSRngb5+NJjQy1RS8DNGQfc4xBotjq8wN bmSRX0RjyGnjX8xBEsw4gD33305ta6KqBGUoJJdCOeLDoiIcLZ0j0O4jX1JqICilUfBRjlpb3z2Qx MMu3aLTkBNa2pd84T0XamsH+n/Kfbvo94DCPcqLcqA9K0khPIE+q36U5m07F0Z8TUs/1PB7fZPbJB us1P6bqZGPDEuNO7t1blLFOBL+Huo31pMghqQtwW/DCYcO1HgnUWodCSoR/82x7Y5tBmZ+yHstm0d azG49vPA==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:32362 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bDvP8-000Zgh-Fa; Fri, 17 Jun 2016 16:09:54 +0100 In-Reply-To: (Dmitry Gutov's message of "Fri, 17 Jun 2016 15:06:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119675 Archived-At: Dmitry Gutov writes: > On 06/17/2016 09:54 AM, Eli Zaretskii wrote: > >> (setenv "FOO") works for me. > > setenv works destructively. To use it and remain good citizens, we'd have to > `(copy-sequence process-environment)` every time we call a Git command. > > Maybe that's not huge in the grand scheme of things, but it certainly looks > wasteful. I used this in my tests.... (let ((foo (getenv "FOO"))) (unwind-protect (progn (setenv "FOO") (apply 'git-program args)) (setenv "FOO" foo))) It's why I that setting and unsetting GIT_DIR seemed a bit of a pain earlier. It should work though. Phil