From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Date: Tue, 12 Jul 2016 16:02:57 -0700 Message-ID: <87d1miqx26.fsf@cochranmail.com> References: <87k2gr49lp.fsf@cochranmail.com> <87eg6yvfgm.fsf@cochranmail.com> <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468364667 9481 80.91.229.3 (12 Jul 2016 23:04:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 23:04:27 +0000 (UTC) Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 13 01:04:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bN6is-0008Bd-Jc for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 01:04:14 +0200 Original-Received: from localhost ([::1]:43991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6ir-0005z1-MX for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 19:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6il-0005yw-8t for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 19:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN6ih-0003Ln-0D for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 19:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6ig-0003Lj-Mi for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 19:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bN6ig-000313-Ao for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 19:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146836459611538 (code B ref 23957); Tue, 12 Jul 2016 23:04:02 +0000 Original-Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 23:03:16 +0000 Original-Received: from localhost ([127.0.0.1]:48888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN6hv-000302-RE for submit@debbugs.gnu.org; Tue, 12 Jul 2016 19:03:16 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:34093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN6hu-0002zs-1c for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 19:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=AB5OfXVpdiFWLiatEtf6QgRG5FQ=; b=mrApZ v55lCRiHvzoXEDcc651fYeDiTXtcLnYY17PccTNcj/ViNmPcctsuV83YZBAV8sY7 tfAANwpY1TGGmed96wsXgH+JzT7Sd5uyWb8fkwzqlrsW7YM1Gop/s44FGWoIV/kO k7jKbnrQ5AuozffGU5uXmngA7y5mjRxbGLh2hEfpIIB6seUSWDWGAU1IdomTTPZx axdhuh38/KfeNLI8W8+EO8AZKhokISHaiVyzKqPjYqp/q0+nkpNPKsUvAFVNs1UW GjvJNLHWwDAIgw7JDwupZXiycLXS3R89ti2vFh6ZXeGI+9tQAWViLDQ6/AGzBUs4 +0Uq6blySZcxts1gQ== Original-Received: (qmail 19250 invoked by uid 0); 12 Jul 2016 23:03:11 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=DxPqJ3lSntjreTVMriLLhpSw69OHsqwEAti+RLexnWfFgIp7YSRH2DREECh3mzP+DSPqJUXE4v6m0oWe2mzMbQ==; Original-Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 23:03:11 -0000 In-Reply-To: <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> (Drew Adams's message of "Tue, 12 Jul 2016 20:06:54 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120971 Archived-At: Drew Adams writes: >> I'd personally argue that anyone making an explicit check for t, or >> anything that particularly needs t rather than any true value is just >> asking for lossage, but I can see why people would disagree with that >> assertion. > > It doesn't matter what we might think of such a check. The point > is that such checks might exist, and there is really no good > reason (that I can see) for breaking such code. Again: anyone > can already use `symbol-function' to get the desired effect, and > its name speaks much better to the combined behavior desired in > that case. >> FWIW, In every placed I changed occurrences of fboundp to >> symbol-function, both in Lisp and C, used only the truthiness >> of the return rather than explicitly checking for t. > > That's irrelevant (IMO). The code that GNU distributes with > Emacs is but a small part of the Emacs-Lisp code that is out > there. > >> I also ran the test suite with and without my patch applied, >> and noticed no difference in the number of failing tests. > > Again - you were testing in the tiny GNU Emacs distributed-code > sandbox. The Emacs world is a much bigger box. Fair enough. I was never going to cast a net big enough to hit everything. I agree with Stefan that most functions will be behave fine in the face of the change, but given his hesitation, I'm not going to push it. You guys know better than I do. >> Anyways, I'm willing to toss this patch and do something else >> if that is the general consensus. > > I can't speak for the consensus, but that would be my hope. And > thanks for pitching in! Sorry to seem so critical of a first foray > into helping. Nah, don't worry about. I was expecting /something/ to snag my patch. You clearly expressed your concerns about my changes, and we were able to discuss and be civil. Best I can ask for, really. In the end, I'll end up doing a cleanup of some sort, even if all that is is removing the FIXME. I've been hearing about how there are less and less people that understand the C core of Emacs, so I'm aiming to help by becoming one of those people. Barring any extreme levels of inter-personal friction in getting things accomplished, I'm hopefully just getting started with this. Thanks, ~Robert Cochran