From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#17862: 24.3; regexp-opt docstring is incorrect Date: Thu, 25 Aug 2016 21:08:34 -0400 Message-ID: <87d1kwtjzh.fsf@users.sourceforge.net> References: <87zip19rm4.fsf@users.sourceforge.net> <87lh0j9rwg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472173760 18677 195.159.176.226 (26 Aug 2016 01:09:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Aug 2016 01:09:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 17862@debbugs.gnu.org, Andreas Schwab To: immerrr again Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 26 03:09:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bd5dz-0004Rf-LK for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Aug 2016 03:09:15 +0200 Original-Received: from localhost ([::1]:58573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd5dx-00084q-5B for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Aug 2016 21:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd5dq-00080O-V0 for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2016 21:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bd5dm-0004KL-Jd for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2016 21:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd5dm-0004KC-GJ for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2016 21:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bd5dm-0001NM-A5 for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2016 21:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2016 01:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17862-submit@debbugs.gnu.org id=B17862.14721737055232 (code B ref 17862); Fri, 26 Aug 2016 01:09:02 +0000 Original-Received: (at 17862) by debbugs.gnu.org; 26 Aug 2016 01:08:25 +0000 Original-Received: from localhost ([127.0.0.1]:40938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bd5dB-0001MK-BH for submit@debbugs.gnu.org; Thu, 25 Aug 2016 21:08:25 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:36807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bd5d9-0001M5-Re for 17862@debbugs.gnu.org; Thu, 25 Aug 2016 21:08:24 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id e63so305378180ith.1 for <17862@debbugs.gnu.org>; Thu, 25 Aug 2016 18:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sIyCgFsAfl6DJ9OheIbLR6OPtXa0OuFCC+93MNgpWhM=; b=WBrhUmQBgwbzg6HcurWm4S+sSB6IWZCVkzEchIMpaDAum1pRY4opQPeW9imiKRrWue kl+tAmHABs0VzWISp1opmyU7a9XGK0qo9Pt2J/8YdH31/OnW8tKefc1H+yxqPB0u5D8v /AXx2oaskp0ykKJZodpggBS1+5ozigBNrylqeYGGXtnuFnBSBJa/+IsTj7c87sNF7lz7 UDEeqn+nVbORHKdfq96Jc67RuboIOMirZCeJR0IluQar1d+Zc3D5UyJD0AVPZUAZcEmQ q90nrKcZ7f+yKTh7jUapmxRtphNgLhBAn9HjMPnSQ9J9U+J699RLPQh0w1WGE/RG3zKE mHZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=sIyCgFsAfl6DJ9OheIbLR6OPtXa0OuFCC+93MNgpWhM=; b=PfJJWH1fkMqETgnJKLCiRsrRllplWVuNNCO/Ivt3z76JJPUGCPdQF62Wg18L13Q5tD 4zk8bUoRnWyJtX6+DePnV4spUGb0KSrYO6wmiikdp4Nk9Mu0b56xTrYN6m2E40hcpTi0 u/gOt1gDUWYFATOR1bRQTU63bcQ9ijYzDi24zZ3Rua1aMwfztdOmQ4OiHzfyz6KRN+6c 58HA87MZ2opC2QjUoYr/ZC1x1r6ibjwVKEPSFNY6+KgIUMF+wOSpRb8ARhlVg8pnyIzS XBb+3IrEVrcBZRG/QID/OQ6lBO6mGDJihsNHZDurNu39krEboGTCQAy8HKQRmjnTjd+T S9iA== X-Gm-Message-State: AEkoousvLK4jnX7HQV9zJlEE+6FWoUVqpRgfY6w59hnNKwPdDLxqXmeuwfnkKzcB+MOKsQ== X-Received: by 10.36.144.68 with SMTP id x65mr8915954itd.12.1472173698196; Thu, 25 Aug 2016 18:08:18 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id r200sm1506864itc.13.2016.08.25.18.08.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2016 18:08:17 -0700 (PDT) In-Reply-To: (immerrr again's message of "Thu, 25 Aug 2016 16:21:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122675 Archived-At: immerrr again writes: > Sorry about that, other things took priority. No problem, I thought maybe you had gone on vacation and forgotten all about this :) It's not really high priority anyway, just that it would be nice to get it in before the 25.1 release since it's a doc fix. > +@code{nil} > + if all @var{strings} are single-character, the resulting regexp is > + not surrounded, otherwise it is surrounded by @samp{\(?:} and > + @samp{\)}. You forgot to update this sentence to be like the one in the docstring. > +(defun simplified-regexp-opt (strings &optional paren) > + (let ((parens (cond ((stringp paren) (cons paren "\\)")) Oh right, I missed the stringp case in my definition, good catch. > +nil > + the resulting regexp is surrounded by \\(?: and \\), if it is > + necessary to ensure that postfix operator appended to it will ^^^ > + apply to the whole expression. Missing the word "a" there, I think. Other than that, looks good to me.