From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24778: 25.1; cl-assert always calls the default debugger on assertion failures Date: Fri, 04 Nov 2016 21:58:18 -0400 Message-ID: <87d1iapu11.fsf@users.sourceforge.net> References: <87mvhnqsg2.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478311105 4272 195.159.176.226 (5 Nov 2016 01:58:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Nov 2016 01:58:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24778@debbugs.gnu.org To: David Shepherd Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 05 02:58:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2qFH-0007so-CR for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Nov 2016 02:58:11 +0100 Original-Received: from localhost ([::1]:41751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2qFK-0004Ql-BI for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Nov 2016 21:58:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2qFD-0004Pj-76 for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 21:58:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2qF8-0007S0-CG for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 21:58:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58088) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2qF8-0007Rk-7a for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 21:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c2qF7-0000H5-UU for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 21:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Nov 2016 01:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24778 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24778-submit@debbugs.gnu.org id=B24778.14783110611028 (code B ref 24778); Sat, 05 Nov 2016 01:58:01 +0000 Original-Received: (at 24778) by debbugs.gnu.org; 5 Nov 2016 01:57:41 +0000 Original-Received: from localhost ([127.0.0.1]:45254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2qEn-0000GR-BE for submit@debbugs.gnu.org; Fri, 04 Nov 2016 21:57:41 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:33157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2qEl-0000G8-2g; Fri, 04 Nov 2016 21:57:39 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id e187so2516619itc.0; Fri, 04 Nov 2016 18:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3hD+uh3ptsDJsy2oEAHTuCsoPDrpqSpITT2vH+vKUBY=; b=weXb8jqln72CQhMbhHXdsm13xkFKEPfc4C+FnFzVi1W7dTh4QL9dGDiTnwCXex+Hrr lWT2X/6YJHZtO66BCfRTrQg5yL/LppVc6L39SmzsfWMaifhKV4Cxox/Oy76cfPpRWtJO fp/tLtbUfUwe0/dBInWOafpX0HcXfptwGhMWk4FC0K0qoz+1cfvBsmpZDPmhR8emrCJH lZZY69R4livxhb9/PjbisigkeTlWDMQSPoY+SJr3qInUkd/PBABD3LDuCM9OzqBHnX4A a+nLQIFoZ3oWx+EqZ0EEMst2tLNVatriasCYnV/davpMg5ZLRcdUcXIcH1R+NP/q7qpG yexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=3hD+uh3ptsDJsy2oEAHTuCsoPDrpqSpITT2vH+vKUBY=; b=U3vLccu6vg72LoYJMF5ClT0+X7+MMKzc3vmb4+XKA1QZgED2t9x8bshYDSumdyLRHo 3xIJoGcMNO+BXpSrR4nuKrCW33TTc3SjHeyjiB5HDjUT7RBe3bXFV8f75pvi3PPrUjJv qw8xebzB3SszDM12MRs9oY14mLN+o38p0m9zcBq9cZbJ2FVvaCozHXAIkEsHH0o+cMdM BtW4uSFvZucfUWOoASrcDXRNQd4VBKbrSlWS5UXPcr/Vtgo1gEmkmL8ixflcUoY51AhN d8mxQe9y8g2weV9jBI7YKktQO41b2YPG9CySwwnXdacrv/xpJ5divgN7zN3lmYHkopax b5dg== X-Gm-Message-State: ABUngvd++06yF8Hj/Q2PcOIRZlK3CNGtRyz9AlbRYbTHecCfL+9uw7c+XkAi2VR9TKnG9w== X-Received: by 10.36.36.3 with SMTP id f3mr813168ita.101.1478311053262; Fri, 04 Nov 2016 18:57:33 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id a71sm8335032itc.11.2016.11.04.18.57.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Nov 2016 18:57:32 -0700 (PDT) In-Reply-To: <87mvhnqsg2.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 29 Oct 2016 07:56:45 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125364 Archived-At: tags 24778 fixed close 24778 25.2 quit >> >> Removing the lines >> >> (if debug-on-error >> (apply debugger `(cl-assertion-failed ,form ,string ,@sargs)) >> >> from cl--assertion-failed seems to solve the problem, but I don't know >> if that would break other things. > > This debug-on-error clause is new in 25.1 (specifically, it was added by > 61b4c22c "* lisp/emacs-lisp/cl*.el: Use define-inline and move some > code..."), so this looks like a regression to me (and it looks > accidental, at least the commit message says nothing about it). I'd > like to remove it for 25.2. Any objections? I removed that clause in db436e93 "Don't call debug on failed cl-assert"