unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: "Евгени Колев" <evgenysw@gmail.com>
Cc: 26037@debbugs.gnu.org
Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures
Date: Sun, 26 Mar 2017 14:04:45 -0400	[thread overview]
Message-ID: <87d1d352yq.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAMCrgaXZ0T40yvfVtbys5O6hE7i804wN4omjKkM7kn+CySN-qA@mail.gmail.com> ("Евгени Колев"'s message of "Sun, 26 Mar 2017 20:29:55 +0300")

Евгени Колев <evgenysw@gmail.com> writes:

> The regex is now updated to include all the chars $%&*;@[\]
>
> I got the list of chars from here
> http://perldoc.perl.org/perlsub.html#Prototypes

It looks like "+" is another possible character:

    The + prototype is a special alternative to $ that will act like
    \[@%] when given a literal array or hash variable, but will
    otherwise force scalar context on the argument. This is useful for
    functions which should accept either a literal array or an array
    reference as the argument:

            sub mypush (+@) {

>
> This is the diff, please let me if it can be improved:
>

> ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'.
> ;; Be careful not to match "sub { (...) ... }".
> - ("\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([^)]+\\))"
> + ("\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([][$%&*;@\\]+\\))"

Please update the comment too.

And if it's not too much trouble could you add a commit message as
described in CONTRIBUTE?  (And then post the output from 'git
format-patch' instead of 'git diff')





  reply	other threads:[~2017-03-26 18:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 16:57 bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Evgeni Kolev
2017-03-11 14:26 ` npostavs
2017-03-15  2:08 ` npostavs
2017-03-16  0:49 ` npostavs
2017-03-18 14:24   ` Евгени Колев
2017-03-18 15:58     ` npostavs
2017-03-26 17:29       ` Евгени Колев
2017-03-26 18:04         ` npostavs [this message]
2017-03-28  3:34 ` bug#26037: [Евгени Колев] " npostavs
2017-03-28  3:41   ` npostavs
2017-03-29  6:28     ` Евгени Колев
2017-03-29 23:46       ` npostavs
2017-04-01 21:40         ` npostavs
2017-04-03  7:49           ` Евгени Колев

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1d352yq.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=26037@debbugs.gnu.org \
    --cc=evgenysw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).