bug#26053: No release notice in 25.2 rc2 ChangeLog

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Package: emacs
Severity: minor

I noticed that the 25.2 rc2 ChangeLog has no "Version 25.2 released" entry.
In fact the file has no entries all, it's all boilerplate.
admin.el's add-release-logs is supposed to add it.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Glenn Morris wrote:

> I noticed that the 25.2 rc2 ChangeLog has no "Version 25.2 released" entry.
> In fact the file has no entries all, it's all boilerplate.
> admin.el's add-release-logs is supposed to add it.

PS whereas etc/HISTORY has the anticipated release date from RC1, which
predates RC2. That date has been committed to etc/HISTORY in the
repository - I recommend not committing until the actual release has
been made.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Nicolas Petton]

Hi Glenn,

I'm preparing the release, and I noticed that the ChangeLog file only
contains one entry with the following:

  2017-04-14  Nicolas Petton  <nicolas@petton.fr>
  
  	* Version 25.2 released.

Then it directly refers to ChangeLog.2:

  See ChangeLog.2 for earlier changes.

Which is rather odd, so I looked at the 25.1 release, and it has the
same almost empty ChangeLog file.  So this is either expected, or maybe
nobody noticed this when I did the last release?

The 24.5 tarball doesn't have this issue since back then there was only
one ChangeLog file.

My question is, was it intended to have the ChangeLog file with only one
entry (for the release)?

Cheers,
Nico

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Nicolas Petton wrote:

> I'm preparing the release, and I noticed that the ChangeLog file only
> contains one entry with the following:
>
>   2017-04-14  Nicolas Petton  <nicolas@petton.fr>

(Presumably you want to use a date some time in the future?)

>   	* Version 25.2 released.
>
> Then it directly refers to ChangeLog.2:
>
>   See ChangeLog.2 for earlier changes.
>
> Which is rather odd, so I looked at the 25.1 release, and it has the
> same almost empty ChangeLog file.  So this is either expected, or maybe
> nobody noticed this when I did the last release?

I think it's expected in this new system.
Of course, you can split the two files up differently if you want to put
more effort into it.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Eli Zaretskii]

> From: Nicolas Petton <nicolas@petton.fr>
> Cc: 26053@debbugs.gnu.org
> Date: Fri, 14 Apr 2017 23:14:01 +0200
> 
> I'm preparing the release, and I noticed that the ChangeLog file only
> contains one entry with the following:
> 
>   2017-04-14  Nicolas Petton  <nicolas@petton.fr>
>   
>   	* Version 25.2 released.
> 
> Then it directly refers to ChangeLog.2:
> 
>   See ChangeLog.2 for earlier changes.
> 
> Which is rather odd, so I looked at the 25.1 release, and it has the
> same almost empty ChangeLog file.

In 25.1, the file ChangeLog is almost empty, but the entry about 25.1
release is in ChangeLog.2.

> My question is, was it intended to have the ChangeLog file with only one
> entry (for the release)?

Not sure, but how does that ChangeLog file get created?  Which command
or Makefile rules cause its creation?

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Eli Zaretskii wrote:

> Not sure, but how does that ChangeLog file get created?  Which command
> or Makefile rules cause its creation?

M-x add-release-logs

See make-tarball.txt.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Eli Zaretskii wrote:

> In 25.1, the file ChangeLog is almost empty, but the entry about 25.1
> release is in ChangeLog.2.

Yes, it wasn't supposed to happen that way.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: Nicolas Petton <nicolas@petton.fr>,  jwiegley@gmail.com,  26053@debbugs.gnu.org
> Date: Mon, 17 Apr 2017 13:06:24 -0400
> 
> Eli Zaretskii wrote:
> 
> > Not sure, but how does that ChangeLog file get created?  Which command
> > or Makefile rules cause its creation?
> 
> M-x add-release-logs

So you are saying that ChangeLog in the emacs-25.1 tarball was just
Nicolas's personal file?  Then avoiding that in 25.2 should be easy:
Nicolas should make sure he doesn't have such a file when he runs
add-release-logs.  Right?

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Glenn Morris]

Eli Zaretskii wrote:

> So you are saying that ChangeLog in the emacs-25.1 tarball was just
> Nicolas's personal file?  Then avoiding that in 25.2 should be easy:
> Nicolas should make sure he doesn't have such a file when he runs
> add-release-logs.  Right?

I don't really get what you are saying.

I believe the procedure I've tried to document and implement in
make-tarball.txt and admin.el make sense, but then I would think that.
It already checks for a personal ChangeLog.

Feel free to improve the system or replace it as you see fit.
Frankly I suspect no-one cares about ChangeLogs.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: nicolas@petton.fr,  jwiegley@gmail.com,  26053@debbugs.gnu.org
> Date: Mon, 17 Apr 2017 13:22:45 -0400
> 
> Eli Zaretskii wrote:
> 
> > So you are saying that ChangeLog in the emacs-25.1 tarball was just
> > Nicolas's personal file?  Then avoiding that in 25.2 should be easy:
> > Nicolas should make sure he doesn't have such a file when he runs
> > add-release-logs.  Right?
> 
> I don't really get what you are saying.
> 
> I believe the procedure I've tried to document and implement in
> make-tarball.txt and admin.el make sense, but then I would think that.
> It already checks for a personal ChangeLog.

Yes, and it seems to have detected, correctly, that ChangeLog should
not be tagged with the "Emacs 25.1 released" entry.  So the procedure
works fine, thanks.

I was just wondering how come we have a ChangeLog (in addition to
ChangeLog.2) file in the 25.1 tarball, and that ChangeLog has only one
entry, about updating AUTHORS.  My hypothesis is that Nicolas ran
add-release-logs, which correctly put the release entry in
ChangeLog.2, and later updated AUTHORS, leaving the log entry in
ChangeLog.  make-tarball then added that ChangeLog to the tarball.

> Feel free to improve the system or replace it as you see fit.
> Frankly I suspect no-one cares about ChangeLogs.

I think we do care, otherwise this bug would have been closed right
away or ignored.

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> So you are saying that ChangeLog in the emacs-25.1 tarball was just
> Nicolas's personal file?  Then avoiding that in 25.2 should be easy:
> Nicolas should make sure he doesn't have such a file when he runs
> add-release-logs.  Right?

The ChangeLog in the emacs-25.1 tarball contains only one entry, but why
do you say it was just my personal file?

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

bug#26053: No release notice in 25.2 rc2 ChangeLog

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I was just wondering how come we have a ChangeLog (in addition to
> ChangeLog.2) file in the 25.1 tarball, and that ChangeLog has only one
> entry, about updating AUTHORS.  My hypothesis is that Nicolas ran
> add-release-logs, which correctly put the release entry in
> ChangeLog.2, and later updated AUTHORS, leaving the log entry in
> ChangeLog.  make-tarball then added that ChangeLog to the tarball.

Yes, that's most probably what happened.

I'll make sure that the ChangeLog is correct for this release though :)

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]