From: npostavs@users.sourceforge.net
To: Reuben Thomas <rrt@sc3d.org>
Cc: 25936@debbugs.gnu.org, Stephen Deasey <sdeasey@gmail.com>
Subject: bug#25936: Fix for whitespace.el to make it read tab-width and indent-tabs-mode correctly
Date: Tue, 18 Apr 2017 08:06:23 -0400 [thread overview]
Message-ID: <87d1c9syww.fsf@users.sourceforge.net> (raw)
In-Reply-To: <874lyj4jxg.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Thu, 23 Mar 2017 20:06:51 -0400")
npostavs@users.sourceforge.net writes:
> Reuben Thomas <rrt@sc3d.org> writes:
>
>> However, on further investigation, I can't see why these local variables
>> are needed. Currently, whitespace-mode makes buffer-local copies of
>> indent-tabs-mode and tab-width, with names prefixed by "whitespace-". But
>> these variables are buffer-local if necessary already, and whitespace-mode
>> never tries to change them.
>
> These variables seem to have been introduced in [1: 55d1cfe870]. I
> agree that it looks like there is no need for them, but I'll wait
> another couple weeks in case someone else has some insights. Adding
> author of that commit (and the person mentioned as "suggesting" it) on
> CC in case they might remember anything about it.
>
> 1: 2008-04-16 03:41:17 +0000 55d1cfe8703c5829bacc8d129277f1f9b33950f6
> Honor the indent-tabs-mode and tab-width setting from user.
I guess they won't answer. The compiler is telling me you missed a
reference of whitespace-tab-width though.
whitespace.el:2095:45:Warning: reference to free variable
‘whitespace-tab-width’
next prev parent reply other threads:[~2017-04-18 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 13:48 bug#25936: Fix for whitespace.el to make it read tab-width and indent-tabs-mode correctly Reuben Thomas
2017-03-24 0:06 ` npostavs
2017-04-18 12:06 ` npostavs [this message]
2017-04-19 23:25 ` Reuben Thomas
2017-04-21 3:17 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1c9syww.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25936@debbugs.gnu.org \
--cc=rrt@sc3d.org \
--cc=sdeasey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).