unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Drew Adams <drew.adams@oracle.com>
Cc: Vincent Lefevre <vincent@vinc17.net>, Alex <agrambot@gmail.com>,
	23007@debbugs.gnu.org
Subject: bug#23007: 24.5; buggy interactive search with middle click
Date: Mon, 29 May 2017 20:53:24 -0400	[thread overview]
Message-ID: <87d1ar412z.fsf@users.sourceforge.net> (raw)
In-Reply-To: <3858231a-8ba1-47a7-a4fa-f516ea1eba22@default> (Drew Adams's message of "Mon, 29 May 2017 17:41:43 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

>> > +      (let ((overriding-terminal-local-map nil))
>> > +        (setq binding (key-binding (this-command-keys-vector) t)))
>> 
>> IMO, it would be better style to do something like
>> 
>> (let ((binding (let ((overriding-terminal-local-map nil))
>>                  (key-binding (this-command-keys-vector) t))))
>>   ...)
>  
> (let* ((overriding-terminal-local-map nil)
>        (binding (key-binding (this-command-keys-vector) t)))
>   ...)

Check https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23007#8, we need to
avoid binding `overriding-terminal-local-map' in "...".





  reply	other threads:[~2017-05-30  0:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  3:10 bug#23007: 24.5; buggy interactive search with middle click Vincent Lefevre
2017-05-29 19:56 ` Alex
2017-05-29 23:56   ` npostavs
2017-05-30  0:41     ` Drew Adams
2017-05-30  0:53       ` npostavs [this message]
2017-05-30  1:07         ` Drew Adams
2017-05-30  1:28           ` npostavs
2017-05-30  2:04             ` Drew Adams
2017-05-30  2:47     ` Alex
2017-05-30  4:44       ` Drew Adams
2017-05-30 11:47       ` npostavs
2017-06-01 22:09         ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1ar412z.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=23007@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    --cc=drew.adams@oracle.com \
    --cc=vincent@vinc17.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).