From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Date: Sun, 05 Nov 2017 12:20:02 -0500 Message-ID: <87d14w7id9.fsf@users.sourceforge.net> References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509902472 12046 195.159.176.226 (5 Nov 2017 17:21:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2017 17:21:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com, tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 05 18:21:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOba-0002up-Om for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 18:21:07 +0100 Original-Received: from localhost ([::1]:45116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBObh-0008Lw-OG for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 12:21:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBObZ-0008Kp-KR for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBObW-0000PX-H9 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:21:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBObW-0000PF-Bt for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBObW-0006KH-3K for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2017 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.150990241224225 (code B ref 28797); Sun, 05 Nov 2017 17:21:02 +0000 Original-Received: (at 28797) by debbugs.gnu.org; 5 Nov 2017 17:20:12 +0000 Original-Received: from localhost ([127.0.0.1]:52501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOai-0006Ia-J0 for submit@debbugs.gnu.org; Sun, 05 Nov 2017 12:20:12 -0500 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:55591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOaf-0006IF-Pw; Sun, 05 Nov 2017 12:20:10 -0500 Original-Received: by mail-io0-f176.google.com with SMTP id p186so13327873ioe.12; Sun, 05 Nov 2017 09:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WrF80aVkjfln+ikQ9KVqRVhyepZNL4at+aa4gl5J0IQ=; b=tOXpdUkpskZ5ZM3+B000e/AfDaUBfzTfEmMCFWeamD5fWJfpt341XfiMaypvn37v12 2uiJWdij/cmcBd2OGIhrpYBBSsVloFMIo5TtTvgy3QYUYgo0JlYpPQcmFOCR3+YgEJNo be0slZxTi5zeRbKl+NlUuJJ0pqBrh1K414EsP7pEQX32vE7Qa4aAj3KdId6a7Obl0AcF 31Nw8AEmEE43vXdUQASu6hoI5QNU0yJLL4Ir15+yPKGXzm61iSKhH4LcuQPveCEIaA7e PiOJKOVcEQaY86YnC/xwej0hsbKCLS9YOes+hm62DjK2ByMCgSsD/lpaV5DBu0KXLNAa 300g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=WrF80aVkjfln+ikQ9KVqRVhyepZNL4at+aa4gl5J0IQ=; b=VJKi+vBEbbKm3ukpb5fbQTPuQ3eV/ily0jB4hlPjh0FGvD0qRhrG6OtWIHc3htH8An 9Py3yz5kS4g5snACR+kwfyMMut7KFGijC5RnQ+J1ak9R5KuJHQEfQrVLzQfUY153S+70 3BN+uiGo28pJuUllEGx7w+YjrhfcV/oymElyz2dtSlfXnVasVbFQcA1Ex+rU3Hx3BB+b a4mmg766cshzFC4oAfIRq/UecNkOlCZpDC0+wKaRiZCoAcDzUIGgNIu+2e0PduMfoKJS 4kU8O79alLsAQOAqdK91awXgzsEMxdp2N9DjOI+uDqKUZ2XrWkHOAHCTB6waoLCdmcs3 lhHw== X-Gm-Message-State: AJaThX4TfM3gjHoqhA6fL354U1mwW2dmEdOdZQydaieiQq6WeLXxajU4 3aVffO/2khMkU6du4LAuyHWJEw== X-Google-Smtp-Source: ABhQp+SbIHGNr2hvghqO5RAYRk5EAHH8az0ZndxKtbIxhsTg5t8bUNF9H4gRC8CUTfX8zDL7BNE/iQ== X-Received: by 10.107.112.3 with SMTP id l3mr17064778ioc.105.1509902404180; Sun, 05 Nov 2017 09:20:04 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j71sm4356414itj.2.2017.11.05.09.20.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 09:20:03 -0800 (PST) In-Reply-To: <83o9pbjh8b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 16:43:33 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139475 Archived-At: tags 28797 fixed close 28797 26.1 quit Eli Zaretskii writes: >> The resulting error will look like >> >> file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo >> >> It's not quite the perfect sentence envisioned on the OP, but it gets >> all the information across, with punctuation separating the parts. > > OK, close enough for me. > >> >> condition-case-unless-debug for #2. >> > >> > This is quite a radical change in very old behavior, so if it is >> > deemed a good idea, it should go to master. >> >> Hmm, it doesn't seem that radical to me, but I don't have a problem >> putting it only to master, or even not doing that at all and just saying >> the user should use debug-on-signal. > > It's radical because we never produce backtrace in similar cases > anywhere else in Emacs. > > Let's wait to hear what others think about this part. I've pushed just the error-message-string part to emacs-26. Setting debug-on-signal is the documented way of getting a backtrace in this sort of case, so I think it's good enough to just leave as is. I think Tino's patch is probably a good idea, but it's not related to this bug, so I'm closing it now. [1: efd0371c23]: 2017-11-05 11:38:38 -0500 Improve dired deletion error handling (Bug#28797) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=efd0371c23c5dd04d73980b42d7cf64bbceccb9a