From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#28587: 26.0.60; Don't write object name strings in object-write method Date: Wed, 08 Nov 2017 13:01:34 -0800 Message-ID: <87d14sscwh.fsf@ericabrahamsen.net> References: <87efqvg5tw.fsf@ericabrahamsen.net> <87o9octu8m.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510174932 21190 195.159.176.226 (8 Nov 2017 21:02:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2017 21:02:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28587@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 08 22:02:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCXU6-0005In-4e for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 22:02:06 +0100 Original-Received: from localhost ([::1]:33894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCXUD-00050L-JX for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 16:02:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCXU4-000502-CS for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 16:02:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCXU1-00024E-8v for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 16:02:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCXU1-000246-3b for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 16:02:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCXU0-0007WU-Q2 for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 16:02:00 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 21:02:00 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28587-submit@debbugs.gnu.org id=B28587.151017489827701 (code B ref 28587); Wed, 08 Nov 2017 21:02:00 +0000 Original-Received: (at 28587) by debbugs.gnu.org; 8 Nov 2017 21:01:38 +0000 Original-Received: from localhost ([127.0.0.1]:58998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCXTd-0007CS-QD for submit@debbugs.gnu.org; Wed, 08 Nov 2017 16:01:38 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:56378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCXTb-0007Ag-WA for 28587@debbugs.gnu.org; Wed, 08 Nov 2017 16:01:36 -0500 Original-Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 13514C0087; Wed, 8 Nov 2017 21:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1510174895; bh=2mqnHi7OLMxPGsWVIrfY+xIXHFNJybTgXGhD21Tvtqc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MgiuLiVNMck4Y+a8ZjmH1Ut2xvDjqbrFZ+YSmZl+Va7nk41XMiI1rzYBnHzWbc+Ey crFMQyBXbQH5UAsMnSfLNkn+gFkVKliqtu59Q5iMsMfjgDzEFC6GAbARlihczNlY+0 sWe/YssJksg2BOodAZHWl3K5lpXSNGEfaNPouMoo= In-Reply-To: (Stefan Monnier's message of "Wed, 08 Nov 2017 15:31:07 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139634 Archived-At: On 11/08/17 15:31 PM, Stefan Monnier wrote: >> So where we're at now is, the previous chunk has gone into both master >> and emacs-26. > > Yay! > >> The next patch (below) would only go into master, so as to >> be more conservative about what's emitted. Everything defaults to >> current behavior. > > Looks good, except for: > >> + "When non-nil write the object name in `object-write'. >> +Does not affect objects subclassing `eieio-named'. Writing >> +object names is deprecated as of Emacs 24.4; consider setting >> +this to nil.") > > AFAIK names are deprecated in calls to EIEIO constructors since > Emacs-25 (rather 24.4), and it's only since Emacs-26 that they are > optional in "eieio-presistent" written representations. Okay I see, I got a little confused there. I checked the emacs 25 branch and it ignores an object name string (emacs 24 requires it), so maybe the only important thing is to say: "Note that prior to Emacs version 25 the object name is required." How's that?