bug#29661: 27.0.50; emacs crashing on exchange-point-and-mark

[Robert Marshall <robert.marshall@codethink.co.uk>]

martin rudalics <rudalics@gmx.at> writes:

>> Breakpoint 3, delete_frame (frame=<optimized out>, force=force@entry=XIL(0x98a0)) at frame.c:2062
>> 2062          FOR_EACH_FRAME (frames, frame1)
>> (gdb) p Vframe_list
>> $1 = XIL(0)
>> (gdb) c
>> Continuing.
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> delete_frame (frame=<optimized out>, force=force@entry=XIL(0x98a0)) at frame.c:2064
>> 2064              struct frame *f1 = XFRAME (frame1);
>
> Thanks.  The attached patch should fix that.  Please check.
>
> But I have no idea how to proceed with the x_reply_selection_request
> failure.
>
> martin
>
> diff --git a/src/frame.c b/src/frame.c
> index 5bafbed..66d1b5c 100644
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -2058,7 +2058,7 @@ of them (the selected terminal frame) is actually displayed.
>
>    /* If we've deleted the last_nonminibuf_frame, then try to find
>       another one.  */
> -  if (f == last_nonminibuf_frame)
> +  if (f == last_nonminibuf_frame && !NILP (Vframe_list))
>      {
>        last_nonminibuf_frame = 0;
>
> @@ -2076,7 +2076,7 @@ of them (the selected terminal frame) is actually displayed.
>
>    /* If there's no other frame on the same kboard, get out of
>       single-kboard state if we're in it for this kboard.  */
> -  if (kb != NULL)
> +  if (kb != NULL && !NILP (Vframe_list))
>      {
>        /* Some frame we found on the same kboard, or nil if there are none.  */
>        Lisp_Object frame_on_same_kboard = Qnil;
> @@ -2093,7 +2093,9 @@ of them (the selected terminal frame) is actually displayed.
>    /* If we've deleted this keyboard's default_minibuffer_frame, try to
>       find another one.  Prefer minibuffer-only frames, but also notice
>       frames with other windows.  */
> -  if (kb != NULL && EQ (frame, KVAR (kb, Vdefault_minibuffer_frame)))
> +  if (kb != NULL
> +      && EQ (frame, KVAR (kb, Vdefault_minibuffer_frame))
> +      && !NILP (Vframe_list))
>      {
>        /* The last frame we saw with a minibuffer, minibuffer-only or not.  */
>        Lisp_Object frame_with_minibuf = Qnil;

Thanks, it now no longer crashes there, but crashes elsewhere but looks
to about to terminate in a more controlled manner?

#1  check_glyph_memory () at dispnew.c:2264
        tail = XIL(0)
#2  0x00000000004ecead in shut_down_emacs (sig=sig@entry=0, stuff=stuff@entry=XIL(0)) at emacs.c:2107
No locals.
#3  0x00000000004bbdeb in x_connection_closed (dpy=dpy@entry=0x15e5800, error_message=<optimized out>, 
    error_message@entry=0x7fffffffcda0 "Connection lost to X server ':0'", ioerror=ioerror@entry=true) at xterm.c:9806
        tail = <optimized out>
#4  0x00000000004bbe96 in x_io_error_quitter (display=0x15e5800) at xterm.c:9915
        buf = "Connection lost to X server ':0'\000\315\377\377\377\177\000\000 \316\377\377\377\177\000\000\000X^\001\000\000\000\000\276-q\364\377\177\000\000Pj^\001\000\000\000\000\001\000\000\000\000\000\000\000\360\274^\001\000\000\000\000\240\330\240\364\377\177\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\300{\355\000\000\000\000\000\363\000@\005\000\000\000\000\000X^\001\000\000\000\000\367\237\336\367\377\177\000\000\005", '\000' <repeats 15 times>, "\340\177\373\000\000\000\000\000\000}m\364\377\177\000\000\000X^\001\000\000\000\000\000X^\001\000\000\000\000t\031@\002\000\000\000\000\025"...
#5  0x00007ffff47154fe in _XIOError () from /usr/lib/x86_64-linux-gnu/libX11.so.6
No symbol table info available.
#6  0x00007ffff4712e5d in _XEventsQueued () from /usr/lib/x86_64-linux-gnu/libX11.so.6
No symbol table info available.
#7  0x00007ffff46f465a in XFlush () from /usr/lib/x86_64-linux-gnu/libX11.so.6
No symbol table info available.
#8  0x00000000004d734c in x_reply_selection_request (dpyinfo=<optimized out>, event=<optimized out>) at xselect.c:694
        reply_base = {
          type = 31, 
          xany = {
            type = 31, 
            serial = 16882611, 
            send_event = 2, 
            display = 0x15e5800, 
            window = 88080627
          }, 
          xkey = {
            type = 31, 
            serial = 16882611, 
            send_event = 2, 
            display = 0x15e5800, 
            window = 88080627, 
            root = 1, 
            subwindow = 324, 
            time = 401, 
            x = 162228637, 
            y = 0, 
            x_root = 0, 
            y_root = 500000, 
            state = 0, 
etc 

I can reliably replicate this error by opening this large file,
searching for a string that only appears on the last line and
exchange-point-and-mark'ing

Robert