* bug#30162: 27.0.50; Wrong order of directories in *Deletions*
@ 2018-01-18 21:34 Juri Linkov
2018-01-23 21:56 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2018-01-18 21:34 UTC (permalink / raw)
To: 30162
This is a regression. The order of directories in *Deletions* was right
in older versions, but not now.
Steps to reproduce:
0. emacs -Q
1. ‘M-!’ mkdir x y z RET
2. ‘C-x d’ RET
3. ‘D D D’ (select dirs x, y, z for deletion)
4. ‘x’ (dired-do-flagged-delete)
Directories in *Deletions* are reversed:
z
y
x
It seems this is a result of the commit 9ecbdee, but I can't find
a related discussion.
I think we should either reverse the list of buffers at the lowest level
in ‘dired-map-over-marks’ (this might cause backward-compatibility
issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
‘dired-internal-do-deletions’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#30162: 27.0.50; Wrong order of directories in *Deletions*
2018-01-18 21:34 bug#30162: 27.0.50; Wrong order of directories in *Deletions* Juri Linkov
@ 2018-01-23 21:56 ` Juri Linkov
2018-01-24 21:44 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2018-01-23 21:56 UTC (permalink / raw)
To: 30162
> This is a regression. The order of directories in *Deletions* was right
> in older versions, but not now.
>
> Steps to reproduce:
>
> 0. emacs -Q
> 1. ‘M-!’ mkdir x y z RET
> 2. ‘C-x d’ RET
> 3. ‘D D D’ (select dirs x, y, z for deletion)
> 4. ‘x’ (dired-do-flagged-delete)
>
> Directories in *Deletions* are reversed:
>
> z
> y
> x
>
> It seems this is a result of the commit 9ecbdee, but I can't find
> a related discussion.
>
> I think we should either reverse the list of buffers at the lowest level
> in ‘dired-map-over-marks’ (this might cause backward-compatibility
> issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
> ‘dired-internal-do-deletions’.
This patch is for the latter:
diff --git a/lisp/dired.el b/lisp/dired.el
index eebf836..eade11b 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3094,7 +3094,7 @@ dired-internal-do-deletions
(dired-recursive-deletes dired-recursive-deletes)
(trashing (and trash delete-by-moving-to-trash)))
;; canonicalize file list for pop up
- (setq files (nreverse (mapcar #'dired-make-relative files)))
+ (setq files (mapcar #'dired-make-relative files))
(if (dired-mark-pop-up
" *Deletions*" 'delete files dired-deletion-confirmer
(format "%s %s "
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#30162: 27.0.50; Wrong order of directories in *Deletions*
2018-01-23 21:56 ` Juri Linkov
@ 2018-01-24 21:44 ` Juri Linkov
0 siblings, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2018-01-24 21:44 UTC (permalink / raw)
To: 30162-done
Done.
>> This is a regression. The order of directories in *Deletions* was right
>> in older versions, but not now.
>>
>> Steps to reproduce:
>>
>> 0. emacs -Q
>> 1. ‘M-!’ mkdir x y z RET
>> 2. ‘C-x d’ RET
>> 3. ‘D D D’ (select dirs x, y, z for deletion)
>> 4. ‘x’ (dired-do-flagged-delete)
>>
>> Directories in *Deletions* are reversed:
>>
>> z
>> y
>> x
>>
>> It seems this is a result of the commit 9ecbdee, but I can't find
>> a related discussion.
>>
>> I think we should either reverse the list of buffers at the lowest level
>> in ‘dired-map-over-marks’ (this might cause backward-compatibility
>> issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
>> ‘dired-internal-do-deletions’.
>
> This patch is for the latter:
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index eebf836..eade11b 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -3094,7 +3094,7 @@ dired-internal-do-deletions
> (dired-recursive-deletes dired-recursive-deletes)
> (trashing (and trash delete-by-moving-to-trash)))
> ;; canonicalize file list for pop up
> - (setq files (nreverse (mapcar #'dired-make-relative files)))
> + (setq files (mapcar #'dired-make-relative files))
> (if (dired-mark-pop-up
> " *Deletions*" 'delete files dired-deletion-confirmer
> (format "%s %s "
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-24 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18 21:34 bug#30162: 27.0.50; Wrong order of directories in *Deletions* Juri Linkov
2018-01-23 21:56 ` Juri Linkov
2018-01-24 21:44 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).