From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 20489@debbugs.gnu.org
Subject: bug#20489: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
Date: Sat, 24 Feb 2018 23:34:35 +0200 [thread overview]
Message-ID: <87d10u5axg.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvpo4v6alc.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Fri, 23 Feb 2018 09:36:19 -0500")
>> +(defun next-error-find-buffer-function-default (&optional avoid-current
>> + extra-test-inclusive
>> + extra-test-exclusive))
>
> This looks like a syntax error to me (function without body). I know
> it's accepted (because various parts of the byte-compiler need special
> hacks to deal with it), but please always put a body (i.e. an explicit nil).
And without body there is no way to add a docstring.
>> +(defvar next-error-find-buffer-function 'next-error-find-buffer-function-default
>
> should just say
>
> (defvar next-error-find-buffer-function #'ignore
Ah, before arriving to the function without body I mistakenly tried #'identity
(that didn't work) whereas I actually intended to try #'ignore.
But the question that I really don't understand is what to do with the function
next-error-buffer-on-selected-frame that now will have no reference in code,
no use by default. How the users are supposed to know that it's possible
to put add-function with this function in the init file? Should we document
this in the docstring of next-error-buffer-on-selected-frame or the docstring
of next-error-find-buffer-function together with examples of using add-function?
next prev parent reply other threads:[~2018-02-24 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180221213025.27066.69339@vcs0.savannah.gnu.org>
[not found] ` <20180221213027.372932052F@vcs0.savannah.gnu.org>
[not found] ` <jwvvaeqxasr.fsf-monnier+emacsdiffs@gnu.org>
2018-02-22 21:38 ` bug#20489: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom Juri Linkov
2018-02-23 14:36 ` Stefan Monnier
2018-02-24 21:34 ` Juri Linkov [this message]
2018-02-25 13:19 ` Stefan Monnier
2018-02-25 20:40 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d10u5axg.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=20489@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).