From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30148: 26.0.91; EWW binding for `r' Date: Fri, 13 Apr 2018 00:29:08 +0200 Message-ID: <87d0z4dpor.fsf@mouse.gnus.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523572085 10975 195.159.176.226 (12 Apr 2018 22:28:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Apr 2018 22:28:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30148@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 13 00:28:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6khF-0002iB-Ds for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2018 00:28:01 +0200 Original-Received: from localhost ([::1]:48759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6kjM-0006H8-2X for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2018 18:30:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6kjF-0006Dl-DD for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 18:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6kjC-000426-AQ for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 18:30:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6kjC-000422-7n for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 18:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f6kjC-00018I-0a for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2018 22:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30148-submit@debbugs.gnu.org id=B30148.15235721614288 (code B ref 30148); Thu, 12 Apr 2018 22:30:01 +0000 Original-Received: (at 30148) by debbugs.gnu.org; 12 Apr 2018 22:29:21 +0000 Original-Received: from localhost ([127.0.0.1]:48706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6kiX-000176-Eq for submit@debbugs.gnu.org; Thu, 12 Apr 2018 18:29:21 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:43503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6kiV-00016y-NJ for 30148@debbugs.gnu.org; Thu, 12 Apr 2018 18:29:20 -0400 Original-Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6kiQ-0006tT-ST; Fri, 13 Apr 2018 00:29:18 +0200 Original-Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6kiL-0006yD-0X; Fri, 13 Apr 2018 00:29:09 +0200 In-Reply-To: (Charles A. Roelli's message of "Wed, 17 Jan 2018 20:45:39 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145213 Archived-At: charles@aurox.ch (Charles A. Roelli) writes: > Normally `l' and `r' in "EWW" go back and forward through the buffer's > history. But when point is on an image (or, oddly, a link -- see > below), `r' instead runs `image-rotate'. Since there are quite some > keys left unbound in both eww-mode-map and in shr-image-map, one of > these bindings should budge. You can have images in other buffers, too, and the `r' for "rotate" seems very natural. And `r' for "return" is a generally accepted command in many Emacs modes, so I don't really know which one to change. > Also, I do not understand why eww-link-keymap is a copy of > shr-image-map, when so many commands that could apply to images do not > apply to links: > > (defvar eww-link-keymap > (let ((map (copy-keymap shr-image-map))) > (define-key map "\r" 'eww-follow-link) > map)) It's presumably to have the image commands not disappear if there's an image in a link. Too bad Emacs doesn't have a way to add several local keymaps using text properties... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no