Hi Noam,

Noam Postavsky <npostavs@gmail.com> writes:

>> I fixed the blocking bug first in a separate patch, and then added a new
>> parameter for commands like sudo, which would prefer :raw-positional
>> arguments after the first non flag argument. I'm still not sure if this
>> is the best name for this idea, so if anyone has a better name I'd be
>> happy to change it!
>
> :parse-leading-options-only?  Perhaps that's too long though.

This sounds better to me, it's more descriptive even if it's longer, so
I'm going to rename it.

> I think you should be able to just terminate the loop here once you have
> pos-argument-found and (memq :raw-positional options) is true, rather
> than passing an arg to eshell--process-option to make the rest of the
> loop iterations into nops.

This approach is a lot cleaner, thanks for noticing that! :)

>
>> -	    (setcdr (nthcdr (1- ai) eshell--args)
>> +            (setcdr (nthcdr (1- ai) eshell--args)
>
> This is just a whitespace change, right?

Whoops, my mistake! Fixing.

Thanks for the review, my updated patches are below.

There's no rush for this, so if you want to hold off on reviewing this
until after the imminent Emacs release, I'm fine with waiting.

-Jay