From: Noam Postavsky <npostavs@gmail.com>
To: Oscar Blanco <orblancog@gmail.com>
Cc: 31289@debbugs.gnu.org
Subject: bug#31289: madx mode for emacs
Date: Thu, 21 Jun 2018 20:50:52 -0400 [thread overview]
Message-ID: <87d0wjr6dv.fsf@gmail.com> (raw)
In-Reply-To: <CAEUbmsovVYxw-K34-ivgBrwXVgcf=RsHVXcw8b6qmSQgtzEu3A@mail.gmail.com> (Oscar Blanco's message of "Fri, 27 Apr 2018 13:00:11 +0200")
Oscar Blanco <orblancog@gmail.com> writes:
> Dear emacs group,
>
> I attach a script that I would like you to consider for the ELPA
> repository.
> This script defines the mad-x mode that highlights buffers with the
> "Methodical Accelerator Design" syntax, by default loaded if the file name
> ends it ".madx".
> ;;; madx.el --- Major mode for editing MAD-X files in Emacs
>
> ;; Copyright (C) 2013, 2016 Oscar BLANCO
> ;; 2017, 2018 Oscar BLANCO, Istituto Nazionale di Fisica Nucleare
> ;; Licensed under the EUPL, Version 1.1
This would have to be changed. I believe GNU ELPA packages must have
copyright assigned to the FSF and be under GPLv3+.
> ;(add-to-list 'auto-mode-alist '("\\.madx\\'" . madx-mode))
This should be uncommented and ;;;###autoloaded I guess.
> (defconst madx-font-lock-warning-face-all
> ;; madx-font-lock-keywords-errordef
> (list
> '("\\<\\(E\\(?:ALIGN\\|FCOMP\\|RROR\\)\\|SETERR\\)\\>"
> . font-lock-warning-face))
> "Highlighting expressions for MAD-X mode (warning-all).")
It looks like this regexp and several others are the result of
regexp-opt; it's better to have the original expression in the source,
e.g.,
`((,(regexp-opt '("EALIGN" "EFCOMP" "ERROR" "SETERR") 'words) . font-lock-builtin-face))
> ;;;###autoload
> (defun madx-mode ()
> "Major mode for editing MAD-X script files."
> (interactive)
> (kill-all-local-variables)
> (setq mode-name "MAD-X")
> (setq major-mode 'madx-mode)
I think if you use `define-derived-mode', it would reduce the need for
some of the boilerplate.
> ;; Set up search
> (add-hook 'madx-mode-hook
> (lambda () (setq case-fold-search t)))
> (run-hooks 'madx-mode-hook))
Why not just plain (setq case-fold-search t) here?
next prev parent reply other threads:[~2018-06-22 0:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 11:00 bug#31289: madx mode for emacs Oscar Blanco
2018-06-22 0:50 ` Noam Postavsky [this message]
2018-10-05 6:52 ` Oscar Blanco
2018-10-24 22:30 ` Noam Postavsky
2018-10-25 22:56 ` Noam Postavsky
2018-10-25 23:18 ` Noam Postavsky
2018-10-26 6:42 ` Eli Zaretskii
2018-10-27 3:27 ` Richard Stallman
2018-10-26 10:41 ` Noam Postavsky
2018-10-26 10:53 ` Noam Postavsky
2018-10-27 10:53 ` Noam Postavsky
2019-09-28 18:13 ` Stefan Kangas
2019-09-28 18:46 ` Noam Postavsky
2019-09-28 18:55 ` Stefan Kangas
2020-01-15 20:26 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0wjr6dv.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31289@debbugs.gnu.org \
--cc=orblancog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).