From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src Date: Tue, 31 Jul 2018 20:29:04 -0400 Message-ID: <87d0v30w1b.fsf@gmail.com> References: <20180717234729.15507-1-eggert@cs.ucla.edu> <83va9c33kk.fsf@gnu.org> <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533083292 28672 195.159.176.226 (1 Aug 2018 00:28:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2018 00:28:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32194@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 01 02:28:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkezo-0007Ln-1K for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Aug 2018 02:28:08 +0200 Original-Received: from localhost ([::1]:32853 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkf1t-0000sX-67 for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jul 2018 20:30:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkf1k-0000qz-Ef for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 20:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkf1e-0001pX-KS for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 20:30:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkf1e-0001pR-G0 for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 20:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkf1e-0006mK-6X for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 20:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Aug 2018 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32194-submit@debbugs.gnu.org id=B32194.153308335425976 (code B ref 32194); Wed, 01 Aug 2018 00:30:02 +0000 Original-Received: (at 32194) by debbugs.gnu.org; 1 Aug 2018 00:29:14 +0000 Original-Received: from localhost ([127.0.0.1]:36794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkf0s-0006ku-8s for submit@debbugs.gnu.org; Tue, 31 Jul 2018 20:29:14 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:55668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkf0q-0006kg-D7 for 32194@debbugs.gnu.org; Tue, 31 Jul 2018 20:29:12 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id p7-v6so7205061itf.5 for <32194@debbugs.gnu.org>; Tue, 31 Jul 2018 17:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jg6K7HQeJfeEvZubbAIO9Oq6fUSdHdF1eOIVX4MIT20=; b=NtxzQvEZiUMlz9swM+UU7hJRfM1u1C1AzYMxz5tzEdMCdjphasioCt1vXMC837IJHL XpiYsQmufEY5rPDV1o1SJ7IvBxvEXKGrf18r6ZJ9zfXgQ3TcJj92Fep59g+x14w8af13 mr8DGE8y9BDzFf+f9iMWM6EKcjW2B0Mb0GMMxSYKyhowtJzfFa68QnZS8raYqyWd+Rwj Jofj2+Ijv/FxhvqkOxbL3MTCBHu37NcK//kTR8xx2g0oc1OzMu2i6pCg9aeLa5zAUOL3 +bnA3W3gFANlbk5jbMNySTlhvIl8Hdqj2F4l2KfwD1NlJT8ll40ZxjDmbdAW/bdUGORc lbWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jg6K7HQeJfeEvZubbAIO9Oq6fUSdHdF1eOIVX4MIT20=; b=JMEzcq78g1C3rpRRM1ss1H4oKOnFC11IENvmXUuXbvmLo9AxMTM4B1MrNZh8vIN5Pu zqPpfEMIFLFS6s9949/rL/LlXF33nv9BTe4KvuH7KaVh8CCLRsx9aPdrUeAj31pnNR5f +CaKU70Snsxaf29EV3OxdNMWuS7jRyEunqMdAY+uuQMRUgPflAgHFKOchdTOydYu3CUi 3r1VDE6kWt7CzfsXIOk1UDpMa3VCWPrX5w8TOB5lDtt+MuMb2ghm3Vd1ru2Y5VYjuLcN c+iQACb56FvoyHJNoZD6xWzrbA7582htsXwE3YFjGCGL2IgNf1gFdy/qRGbOzT/TgW5r 5GYA== X-Gm-Message-State: AOUpUlFU2HK2kGvvnYfW2CkBdrs+0HC5GifOIY6MZl9GEKszIiyqs4Lb hSeUDOLWb9EMyc57L+9IGy7zkMbW X-Google-Smtp-Source: AAOMgpex+fzrrf8tDI2ovGq6ggTXekMduaREQKsmTxJKB8dA4HipgyCR5PbYtT5iNh2VkI1Qfse+pg== X-Received: by 2002:a24:cc07:: with SMTP id x7-v6mr1624874itf.3.1533083346799; Tue, 31 Jul 2018 17:29:06 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g198-v6sm7031730itg.4.2018.07.31.17.29.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 17:29:06 -0700 (PDT) In-Reply-To: <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> (Paul Eggert's message of "Tue, 31 Jul 2018 11:21:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149134 Archived-At: Paul Eggert writes: > Omit the "#ifndef emacs" and "#ifdef REGEX_MALLOC" and "#ifdef > DEBUG" or "#if WIDE_CHAR_SUPPORT" or "#ifdef _REGEX_RE_COMP", > code, as we are no longer interested in compiling outside > Emacs (with or without debugging or native wide char support) > or in avoiding alloca. Is it justified to drop the DEBUG code? Couldn't it still be useful if we want to debug regex engine (and we're not assuming it has/will always have 0 bugs, right)?