From: Noam Postavsky <npostavs@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 32194@debbugs.gnu.org
Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src
Date: Tue, 31 Jul 2018 20:29:04 -0400 [thread overview]
Message-ID: <87d0v30w1b.fsf@gmail.com> (raw)
In-Reply-To: <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> (Paul Eggert's message of "Tue, 31 Jul 2018 11:21:38 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> Omit the "#ifndef emacs" and "#ifdef REGEX_MALLOC" and "#ifdef
> DEBUG" or "#if WIDE_CHAR_SUPPORT" or "#ifdef _REGEX_RE_COMP",
> code, as we are no longer interested in compiling outside
> Emacs (with or without debugging or native wide char support)
> or in avoiding alloca.
Is it justified to drop the DEBUG code? Couldn't it still be useful if
we want to debug regex engine (and we're not assuming it has/will always
have 0 bugs, right)?
next prev parent reply other threads:[~2018-08-01 0:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 23:47 bug#32194: [PATCH] Use Gnulib regex for lib-src Paul Eggert
2018-07-18 16:34 ` Eli Zaretskii
2018-07-31 18:21 ` Paul Eggert
2018-08-01 0:29 ` Noam Postavsky [this message]
2018-08-01 0:59 ` Paul Eggert
2018-08-01 1:10 ` Noam Postavsky
2018-08-01 1:27 ` Paul Eggert
2018-08-02 0:58 ` Noam Postavsky
2018-08-02 1:49 ` Paul Eggert
2018-08-02 1:55 ` Noam Postavsky
2018-08-02 2:42 ` Eli Zaretskii
2018-08-02 3:19 ` Paul Eggert
2018-08-02 10:28 ` Noam Postavsky
2018-08-02 14:05 ` Eli Zaretskii
2018-08-02 14:41 ` Paul Eggert
2018-08-02 14:55 ` Eli Zaretskii
2018-08-02 15:41 ` Paul Eggert
2018-08-04 15:41 ` Eli Zaretskii
2018-08-04 23:34 ` Paul Eggert
2018-08-05 17:58 ` Eli Zaretskii
2018-08-06 2:40 ` Paul Eggert
2018-08-06 10:59 ` Andy Moreton
2018-08-06 14:52 ` Eli Zaretskii
2018-08-06 15:40 ` Andy Moreton
2018-08-06 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0v30w1b.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32194@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).