From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32378: [PATCH] bibtex-next/previous-entry Date: Mon, 06 Aug 2018 22:15:18 -0400 Message-ID: <87d0uuylah.fsf@gmail.com> References: <87lg9jcin1.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533608046 24038 195.159.176.226 (7 Aug 2018 02:14:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2018 02:14:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32378@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 07 04:14:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmrVZ-0006Ag-V0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2018 04:14:02 +0200 Original-Received: from localhost ([::1]:36960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmrXg-000524-I6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2018 22:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmrXZ-00051o-6F for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 22:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmrXV-0007ek-Uv for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 22:16:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmrXV-0007eg-R1 for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 22:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmrXV-0002PF-KA for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 22:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Aug 2018 02:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32378-submit@debbugs.gnu.org id=B32378.15336081279197 (code B ref 32378); Tue, 07 Aug 2018 02:16:01 +0000 Original-Received: (at 32378) by debbugs.gnu.org; 7 Aug 2018 02:15:27 +0000 Original-Received: from localhost ([127.0.0.1]:43059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmrWx-0002OG-51 for submit@debbugs.gnu.org; Mon, 06 Aug 2018 22:15:27 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:36050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmrWv-0002O2-Nq for 32378@debbugs.gnu.org; Mon, 06 Aug 2018 22:15:25 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id r15-v6so12758638ioa.3 for <32378@debbugs.gnu.org>; Mon, 06 Aug 2018 19:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=r+81FT66xnxTO98sTS+N2o+jt//133QNEkjeHOgg8WE=; b=twp9MrwhKIZiUsA1H69N6BELelIhFizfTEzJb9YKMkbnonm/mMnRR4rAfpQj7fYUmv ifqkHJ8ERDFySs++ET9PiP4gw6DBPTqlhWMYmBC4tzTAD+zQOTWHhhU4H7Y4SAiLZsxW mkJqjFtnUbj2k7Axw0BclWrOXFxPqjlfCR4+plYPEh4dTMTAK25EXyt4Eo/9gai2wupU B7nlQftohs1sBiptr+EpfuztHBiACZAVKcitLFAaQa3L9ROqv7e4SJtjQSjxTGMPf2Wo tq70Xk9fWYC1w3qLaNAY2z5Wt5L/bL5d4omHP4JCnlpOpJFLBIpeIf0OzUA/AVaVoIVf +x2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=r+81FT66xnxTO98sTS+N2o+jt//133QNEkjeHOgg8WE=; b=WvhmnXQ/Bbyh9xP/YEFDa7F+772alcQs0wh4rdfApucwP7dAOwP6x6dXDSBaUbQ3+p U3kPrE6pQLfg0AxPYVRpJg2a3jYL5w36JpjLbXQ7n5YvRbuMqEQILxXJwtm2BPmyhSU8 Ero9kPU6iUJ/J9T20PVJmkKFkP49zZt/arui2O5eyjmxrf1GjV9qzaZFfUzIAYIOpCXt ADCR2xE3cUF3GqT+GoXkr90XuVOtAjqkUa6QDGwuTKrqAMbBHKsIMiFpMRiWuE3jRKuO Kr4mQRk/KUm2JSPrHJU0VxDPiVQhasvJ6cC6jETeZn51YUPJVMp/DCI/GpEgcpWycbvu PEGw== X-Gm-Message-State: AOUpUlHY1EWFq411OcgO8PFQKlRftvMwMTS08dpcrSCAyduWIXkQLQZf lC8WWOLuCtg3F5VZRNHw9L8MB+Pv X-Google-Smtp-Source: AA+uWPxOhqDKIYN50IuWKocm2RHVJclr3YxpsuAmalP0koiDEwKGEuSvNzZiwBD1ECzErt+SPoM48w== X-Received: by 2002:a6b:1410:: with SMTP id 16-v6mr2876049iou.23.1533608119990; Mon, 06 Aug 2018 19:15:19 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n142-v6sm6893540itb.3.2018.08.06.19.15.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 19:15:19 -0700 (PDT) In-Reply-To: <87lg9jcin1.fsf@gmail.com> (Alex Branham's message of "Mon, 06 Aug 2018 16:03:30 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149302 Archived-At: Alex Branham writes: > +(defun bibtex-next-entry (&optional arg) > + "Move point ARG entries forward." > + (interactive "p") > + (bibtex-end-of-entry) > + (re-search-forward bibtex-entry-maybe-empty-head nil t (or arg 1)) > + (goto-char (match-beginning 0))) > + > +(defun bibtex-previous-entry (&optional arg) > + "Move point ARG entries backward." > + (interactive "p") > + (bibtex-beginning-of-entry) > + (re-search-backward bibtex-entry-maybe-empty-head nil t (or arg 1)) > + (goto-char (match-beginning 0))) You forgot to check the return value of re-search-forward/backward, if there is no match then (match-beginning 0) might return something unexpected. Alternatively, if you don't expect the match to fail, pass nil for NOERROR.