From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Wed, 19 Dec 2018 02:11:19 +0200 Organization: LINKOV.NET Message-ID: <87d0pyxtnc.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545178630 8652 195.159.176.226 (19 Dec 2018 00:17:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 00:17:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 01:17:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZPXr-00026x-P1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 01:17:03 +0100 Original-Received: from localhost ([::1]:57053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZPZy-0002zm-IJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Dec 2018 19:19:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZPZp-0002yp-SK for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZPZm-0005Ph-J9 for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZPZm-0005On-6n for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZPZl-0005kh-Ru for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 19:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2018 00:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154517869222040 (code B ref 33567); Wed, 19 Dec 2018 00:19:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 19 Dec 2018 00:18:12 +0000 Original-Received: from localhost ([127.0.0.1]:53873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZPYy-0005jQ-Hx for submit@debbugs.gnu.org; Tue, 18 Dec 2018 19:18:12 -0500 Original-Received: from bird.maple.relay.mailchannels.net ([23.83.214.17]:18193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZPYw-0005jH-PO for 33567@debbugs.gnu.org; Tue, 18 Dec 2018 19:18:11 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 59E235C3CF2; Wed, 19 Dec 2018 00:18:09 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a38.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 173D05C3B4F; Wed, 19 Dec 2018 00:18:09 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a38.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 19 Dec 2018 00:18:09 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Spicy-Keen: 3015c19f7871d0fc_1545178689195_954094748 X-MC-Loop-Signature: 1545178689195:1278701274 X-MC-Ingress-Time: 1545178689195 Original-Received: from pdx1-sub0-mail-a38.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a38.g.dreamhost.com (Postfix) with ESMTP id C18C381DF6; Tue, 18 Dec 2018 16:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vmZOMERfO9jo/+o2J5Eqmp3KzPA=; b= iqN40mllki6Ul0vbjpebnE6jQYgLX5H39BqoiZ0gJz/tB3X+fOEPHl+w0r72Ayr/ sz8lazDJ9CEi70qtYv+2uVGzOMuUOUc/guT8ojd/gkTiq5eb00//9gU93fvSOrEB AUTUyALO6OUEsxci6EBWuBIK05NAnz64xu2ERHdS/nM= Original-Received: from mail.jurta.org (m91-129-96-177.cust.tele2.ee [91.129.96.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a38.g.dreamhost.com (Postfix) with ESMTPSA id 306DD81DEC; Tue, 18 Dec 2018 16:18:06 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a38 In-Reply-To: (Dmitry Gutov's message of "Wed, 19 Dec 2018 01:33:30 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudeikedgudefgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddujeejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddujeejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153586 Archived-At: >> I tried to replicate your settings: in emacs -Q I change the default >> foreground with e.g. M-x set-foreground-color RET > > That only seems to change the default's foreground color. Which affects how > the context looks, but not lines with changes. > >> A side note: M-x set-foreground-color RET TAB shows a list >> of colors with different backgrounds, not foregrounds >> as it would be natural to expect, so it is difficult to decide >> what foreground color to select by looking at background colors. >> This needs a separate bug#. > > Indeed, it only gives a rough idea. Reported to bug#33799. >> Ok, let's say I chose M-x set-foreground-color RET LightSeaGreen >> >> Now in diff-mode I see exactly the same fontification with the same >> foreground colors and as seen in the original buffer visited from >> diff-mode by `C-c C-c', plus red/green background added by diff-mode. > > Let me show you a screenshot. I've set some purple-ish foreground using > 'M-x set-foreground-color', and you can see it in certain places. But where > there was the "default" face in the original buffers, in the changes lines > there is now green4 or red4 in the foreground, coming from the respective > faces diff-added and diff-removed. Thanks, I see now. Does it help to remove foreground colors from diff-added and diff-removed? Neither GitHub nor GitLab have foreground green/red colors, only background green/red colors.