From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 27 Dec 2018 00:59:37 +0200 Organization: LINKOV.NET Message-ID: <87d0pnnbc6.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <87imzng7gn.fsf@mail.linkov.net> <87lg4ds5zi.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545865531 24530 195.159.176.226 (26 Dec 2018 23:05:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Dec 2018 23:05:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 27 00:05:26 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIEt-0006Co-1L for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2018 00:05:23 +0100 Original-Received: from localhost ([127.0.0.1]:48639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcIGy-0001VI-Bu for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Dec 2018 18:07:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcIGl-0001UV-W2 for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcIGZ-0005sY-Mu for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:16 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40769) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcIGU-0005b3-JR for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gcIGU-0005Wm-Dy for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Dec 2018 23:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154586561721229 (code B ref 33567); Wed, 26 Dec 2018 23:07:02 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 26 Dec 2018 23:06:57 +0000 Original-Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIGO-0005WJ-0q for submit@debbugs.gnu.org; Wed, 26 Dec 2018 18:06:57 -0500 Original-Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:2614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIGI-0005W7-J9 for 33567@debbugs.gnu.org; Wed, 26 Dec 2018 18:06:53 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 45DE55C43D9; Wed, 26 Dec 2018 23:06:49 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E6D575C449D; Wed, 26 Dec 2018 23:06:48 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 26 Dec 2018 23:06:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Thoughtful: 6f8c139e4bf3e63c_1545865609097_482379952 X-MC-Loop-Signature: 1545865609097:2052841653 X-MC-Ingress-Time: 1545865609096 Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTP id 906B97FC59; Wed, 26 Dec 2018 15:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=LH3iYie3yWLHMseb76bsYLPr+UY=; b= e1JAguV8HLmZgXad94gzaw8F0SpLRbrk4PSC7tQv+F7KOn3RNx9qcyMbp1AHjdcb RBj5AOMD1P9EobUzAuoBWjw2GJ758+lwGbMXFsdb0w/ougZMJMPZpP5iZWYXEbpW fvvmpz7DeZVq7AqsaeavurCC1dQRpbXURQRLueCN41I= Original-Received: from mail.jurta.org (m91-129-108-193.cust.tele2.ee [91.129.108.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTPSA id 707367FC5E; Wed, 26 Dec 2018 15:06:45 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a49 In-Reply-To: (Dmitry Gutov's message of "Wed, 26 Dec 2018 03:40:46 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrtddugddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepledurdduvdelrddutdekrdduleefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtkedrudelfedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153874 Archived-At: >>> Your proposed new colors for added/removed are the same that are used >>> GitHub/GitLab, so this should be a good change. For refine-removed >>> better to use GitLab's color #ffcccc that is very close to the >>> color you proposed. But for refine-added GitLab made the same mistake >>> that GitHub already fixed. So the best color for refine-added is #bbffbb. >> >> After trying to use there colors, I see that their shade is too subtle. >> They might look better on large hunks, and I'm not sure why they look ok >> in the browser, but in Emacs refined colors for small changes are almost >> not noticeable. However, please change them if majority agrees. > > To my eyes, that's a surprising conclusion. > > I wasn't going to argue with your correction to refine-added, even though > I might prefer a slightly lighter variation (because I end up looking at > larger refined regions often). Are you now saying that #ffcccc for > refine-removed (or #d0ffd0, the difference is visible only on large > regions) and #bbffbb for refine-added are hard for you to notice on > smaller regions? I meant that added/removed #eeffee/#ffeeee are harder to notice, and really only on distant corners of the monitor. Also looking down at the LCD screen from a sharp angle can see the inverted colors: green instead of red, and red instead of green :) So color choice is not the exact sciences. > Before we get into deeper discussion (as well as discussing how one finds > out majority's opinion), I have to ask: did you make sure to use the new > refined colors with the new diff-added and diff-removed background colors? Since #eeffee/#ffeeee colors were tested on many users of GitHub/GitLab, please keep them in diff-mode and also install the accompanying change of refine-added/refine-removed. > This is commit a94ac604d8. We can also note that GitHub only refines > smaller chunks: GitHub only refines smaller chunks, but refining large chunks often helps to see real changes with code indentation, e.g. when a let-binding form is added and thus whitespace of indentation shifts the code block. > https://github.com/emacs-mirror/emacs/commit/a94ac604d8c9848b0414ade80a1920b345161656, > so its use of darker backgrounds is more justifiable. > > What do you think of the screenshots? Are the small refined regions hard > for you to see? Or do they look very different in your Emacs? I think this is fine, I have no problems with refine-added/refine-removed, please install refine-added/refine-removed as well.