From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Fri, 04 Oct 2019 19:47:41 +0100 Message-ID: <87d0fcjqk2.fsf@mattleach.net> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> <83a7aka1q5.fsf@gnu.org> <87sgocfh8c.fsf@mattleach.net> <83y2y48f8u.fsf@gnu.org> <87o8z0few1.fsf@mattleach.net> <83sgob98zk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244084"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 37564@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 04 20:57:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGSls-0011Ms-Qb for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2019 20:57:44 +0200 Original-Received: from localhost ([::1]:51204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGSlr-0002tW-B2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2019 14:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36221) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGScW-00066a-4f for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 14:48:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGScU-0005DA-Cc for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 14:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34643) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGScU-0005Cf-9i for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 14:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iGScU-0007cD-5R for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 14:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Leach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2019 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.157021486429245 (code B ref 37564); Fri, 04 Oct 2019 18:48:02 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 4 Oct 2019 18:47:44 +0000 Original-Received: from localhost ([127.0.0.1]:43464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGScC-0007bd-0L for submit@debbugs.gnu.org; Fri, 04 Oct 2019 14:47:44 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:55348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGSc9-0007bT-6r for 37564@debbugs.gnu.org; Fri, 04 Oct 2019 14:47:41 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id 8AC2161C5D; Fri, 4 Oct 2019 19:47:39 +0100 (BST) Original-Received: from hopton.mattleach.net (92.40.249.172.threembb.co.uk [92.40.249.172]) by mx0.mattleach.net (Postfix) with ESMTPSA id A7CC361C21; Fri, 4 Oct 2019 19:47:38 +0100 (BST) In-Reply-To: <83sgob98zk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Oct 2019 05:28:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168340 Archived-At: Eli Zaretskii writes: >> From: Matthew Leach >> Cc: 37564@debbugs.gnu.org >> Date: Tue, 01 Oct 2019 20:24:14 +0100 >> >> > I simply tried "env | fgrep LINES" and I do see the variable, although >> > it wasn't there before I launched Emacs. >> >> I would expect the variable to be there when inside Emacs as it has >> exported it. You should find that it won't exist if ran outside Emacs, >> for example in xterm. > > Sorry, I'm confused. Are we talking about running "M-x term" inside > Emacs, or are we talking about something else? The subject of the bug > report says "term", so I assumed you mean term-mode. Indeed, I'm talking about term-mode (M-x term). Sorry if I didn't make that clear. >> Ah, indeed if I try and resize and print the variable it has updated: >> >> matthew@hopton ~ $ env | grep -i lines >> LINES=30 >> matthew@hopton ~ $ env | grep -i lines >> LINES=12 >> >> I think the issue is that the environment can't be while a process is >> running; the environment variables are fixed when the program has >> started. For a ncurses application this presents a problem as LINES and >> COLUMNS can't be updated when the window size is changed and the program >> handles a SIGWINCH. You can see that on the output above. > > While the process is running, Emacs sends ioctl commands to > communicate the window size changes. Sure but by exporting LINES and COLUMNS (something that other terminal emulators don't do) programs aren't picking up changes in the window size. -- Matt