From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25187: Initialization of `shell-mode-map' is not safe Date: Wed, 09 Oct 2019 09:24:15 +0200 Message-ID: <87d0f6qt40.fsf@gnus.org> References: <49c53840-659f-5e60-a1d9-161a7e1d8004@Alexander.Shukaev.name> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49419"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25187@debbugs.gnu.org To: Alexander Shukaev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 19:24:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFhI-000Cil-Nv for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 19:24:24 +0200 Original-Received: from localhost ([::1]:53008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFhH-00061F-5i for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 13:24:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39744) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI6LJ-0000We-5S for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI6LI-0008Ku-0y for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:25:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI6LH-0008Kq-UW for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI6LG-0007Nb-48 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25187 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 25187-submit@debbugs.gnu.org id=B25187.157060586128297 (code B ref 25187); Wed, 09 Oct 2019 07:25:02 +0000 Original-Received: (at 25187) by debbugs.gnu.org; 9 Oct 2019 07:24:21 +0000 Original-Received: from localhost ([127.0.0.1]:51996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6Ka-0007ML-VP for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:21 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6KZ-0007MB-5d for 25187@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:19 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6KV-0004M9-HM; Wed, 09 Oct 2019 09:24:17 +0200 In-Reply-To: <49c53840-659f-5e60-a1d9-161a7e1d8004@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 00:08:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168728 Archived-At: Alexander Shukaev writes: > consider > > (defvar shell-mode-map > (let ((map (nconc (make-sparse-keymap) comint-mode-map))) [...] > from 'shell.el'. When somebody decides to customize `comint-mode-map' > by, for example, first wiping it out and then filling it again, > > (with-eval-after-load 'comint > ;; Wipe `comint-mode-map': > (setcdr comint-mode-map nil) > ;; Fill `comint-mode-map': > ...) > > then when the `shell' feature is loaded, it will inevitably fail > because `(lookup-key comint-mode-map [menu-bar completion])' may no > longer return a keymap but rather nil or a number. I've now fixed this in Emacs 27 by just removing the nconc from the shell mode map -- shell-mode is derived from comint-mode, so it automatically inherits its map. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no