From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' Date: Wed, 30 Oct 2019 20:44:14 +0100 Message-ID: <87d0eeow6p.fsf@gnus.org> References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167986"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35481@debbugs.gnu.org To: Sebastian Urban Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 21:53:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPuyV-000hba-4X for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 21:53:51 +0100 Original-Received: from localhost ([::1]:44284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPuyT-0003Uv-UF for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 16:53:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44625) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPttv-0003OP-H1 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:45:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPttu-00052b-1M for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPttt-00052P-Tn for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPttt-0007ox-Nn for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy confirmed Original-Received: via spool by 35481-submit@debbugs.gnu.org id=B35481.157246466129971 (code B ref 35481); Wed, 30 Oct 2019 19:45:01 +0000 Original-Received: (at 35481) by debbugs.gnu.org; 30 Oct 2019 19:44:21 +0000 Original-Received: from localhost ([127.0.0.1]:51511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttE-0007nL-Lv for submit@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:20 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttC-0007n6-QI for 35481@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:19 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPtt8-0002xE-R7; Wed, 30 Oct 2019 20:44:17 +0100 In-Reply-To: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> (Sebastian Urban's message of "Sun, 28 Apr 2019 23:31:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170451 Archived-At: Sebastian Urban writes: > In short "table.el" uses text property 'face' (table-cell) which causes > losing of cell highlight when user switches from modes like "Text" or > "Fundamental" to modes that use "Font lock", like "Outline". Also when > user switches back, 'face' is not applied immediately in every cell, but > one by one, when cursor is moved from cell to cell. > > For both problems a solution seems to be an update to "table.el", which > will change 'face' to 'font-lock-face'. > > If it helps, I found 4 places in code that probably need to be changed: > - 'defface table-cell' at line 680, > - 'defun table--put-cell-face-property' at line 5172, > - 'defun table--remove-cell-properties' at line 5189, > - 'defun table--update-cell-face' at line 5209. The patch below does this, but I'm not sure it's right. When we're using font-lock-face instead of face, then things work as normal when we're using global-font-lock-mode, but if that's off, then we won't get any faces at all. Which would be bad. I grepped around, but other modes don't seem to care about that. But I guess it's somewhat unusual for a minor mode to do stuff like this? I think putting both font-lock-face and face on the text would do the trick here, but is that the way to go? diff --git a/lisp/textmodes/table.el b/lisp/textmodes/table.el index 839df035d2..92aaa46ad6 100644 --- a/lisp/textmodes/table.el +++ b/lisp/textmodes/table.el @@ -5151,7 +5151,7 @@ table--put-cell-indicator-property (defun table--put-cell-face-property (beg end &optional object) "Put cell face property." - (put-text-property beg end 'face 'table-cell object)) + (put-text-property beg end 'font-lock-face 'table-cell object)) (defun table--put-cell-keymap-property (beg end &optional object) "Put cell keymap property." @@ -5178,7 +5178,7 @@ table--remove-cell-properties 'table-cell nil 'table-justify nil 'table-valign nil - 'face nil + 'font-lock-face nil 'rear-nonsticky nil 'cursor-sensor-functions nil 'keymap nil) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no