From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#38497: 27.0.50; Frame is not rendered when frame-resize-pixelwise it 't Date: Sat, 07 Dec 2019 21:35:19 +0800 Message-ID: <87d0d0i7hk.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> References: <87wobbjlm0.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <7caf72bb-1dc0-6e6d-430a-5c28295fb80c@gmx.at> <87tv6fjco6.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <20b3b02b-8018-49cd-4ab3-702ccf9e1c28@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243184"; mail-complaints-to="usenet@blaine.gmane.org" To: martin rudalics , 38497@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 04:41:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idnRS-0011AS-Hq for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 04:41:06 +0100 Original-Received: from localhost ([::1]:55348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idnRP-0000B3-1I for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2019 22:41:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50294) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idnOy-00005k-Nt for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:38:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idnOw-0003hA-5y for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:38:32 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idnOU-0003bl-I0 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:38:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idnOU-00058E-GJ for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 03:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38497 X-GNU-PR-Package: emacs Original-Received: via spool by 38497-submit@debbugs.gnu.org id=B38497.157577627319683 (code B ref 38497); Sun, 08 Dec 2019 03:38:02 +0000 Original-Received: (at 38497) by debbugs.gnu.org; 8 Dec 2019 03:37:53 +0000 Original-Received: from localhost ([127.0.0.1]:50253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idnOK-00057O-MB for submit@debbugs.gnu.org; Sat, 07 Dec 2019 22:37:52 -0500 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:39896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idnOJ-00057B-GN for 38497@debbugs.gnu.org; Sat, 07 Dec 2019 22:37:51 -0500 Original-Received: by mail-wr1-f68.google.com with SMTP id y11so12160900wrt.6 for <38497@debbugs.gnu.org>; Sat, 07 Dec 2019 19:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=8We/MoRdwBPwsbSy5iCsJQn+mKTrIwaamgOxfFYwQMM=; b=N/fXpnuAbcrr+VEZjJkLee6LG/GUVrt8qbM+TsHG9OLWegaH8Rgb/lkugaIvfPmHKe 2p9qsBMyGwDLiw+FenPoHDP2Zq8WqiO5LvDkzLH1JpMmyuuNrNGhANmHwcUZH890kzDQ TsLNPde8VrwVqyptpkG2PGbCF7gHTT0MV8v78A0/bUn5tcy1y5AEE45uRIhbyCtfcvLO hHjkOhQkBVnzqIN+7RusMUCjvVEm7++aL+b/Fd7LImScm5Lq45l8JA7SZlLyZxKZESnm HhOB1uTPFxsZbIwyrbdlJVwqG4pNE+NECxp6ICYia/oj7EkxDQ4imK72/TaKP0bZY+Kh tSCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=8We/MoRdwBPwsbSy5iCsJQn+mKTrIwaamgOxfFYwQMM=; b=R/F/Xj2q7JLhHQVm4k0SvQCoXiZK5+Mtbi0Z3i4j38dYXEo1aMy6bT+Rmkdox3k9j6 3QzW8hR2OJ7X5SRHPJWnixm7X+8G4jI8z96CYGNiUbD9rK3R5KpFgLSqo0rV71InGfXj 45h3ZiEikGNp0O1tTg7xoFgXCFsLpKkkTJEaq0786nObrvZV2xDuJZw9fujBG8RBUTQ+ djx8bNUmCmRWJjUgLsR/IogbXA9QoFuVErtPon++yMoxTUAm06GL48J02inEKIl73Te/ JcIqVWhl4wuk0pDk2iIiISh1fKRaVS3GGGC/NfnDGkMUdALlUpCG9wR7Kjj4LfieqHZd 2yEw== X-Gm-Message-State: APjAAAWlh9nJGPnpAwl6o8H2lnK3hrpWHp9PhfK/0eXMvRJ8P7GljcpE rbedTzkaX0lNCZpKKv6A4t0bSs400Hs= X-Google-Smtp-Source: APXvYqyHKLJaHFj2sHPjubWe8d2d4lYRlP6jjC/QyWBhMX/LXt4HsbvsvOfWEskHYp/ZDn3GvBO7JA== X-Received: by 2002:adf:82e7:: with SMTP id 94mr21182515wrc.60.1575725831807; Sat, 07 Dec 2019 05:37:11 -0800 (PST) Original-Received: from localhost ([5.226.137.4]) by smtp.gmail.com with ESMTPSA id f1sm6812298wml.11.2019.12.07.05.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2019 05:37:10 -0800 (PST) In-Reply-To: <20b3b02b-8018-49cd-4ab3-702ccf9e1c28@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173019 Archived-At: --=-=-= Content-Type: text/plain > ... Couldy you try in > widget.c and xterm.c to selectively make frame_resize_pixelwise have > no effect, so we could possibly locate the direct source of the > problem? The attached patch is the minimal patch making the rendering issue disappear. Also, I cannot reproduce the issue when I try to configure emacs just with ./configure --with-x-toolkit=lucid. The options I used to compile emacs in my OS (I am using gentoo) are ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-silent-rules --docdir=/usr/share/doc/emacs-vcs-27.0.9999 --htmldir=/usr/share/doc/emacs-vcs-27.0.9999/html --libdir=/usr/lib64 --program-suffix=-emacs-27-vcs --includedir=/usr/include/emacs-27-vcs --infodir=/usr/share/info/emacs-27-vcs --localstatedir=/var --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp --without-compress-install --without-hesiod --without-pop --with-dumping=pdumper --with-file-notification=inotify --enable-acl --with-dbus --with-modules --without-gameuser --with-libgmp --with-gpm --without-json --without-kerberos --without-kerberos5 --with-lcms2 --with-xml2 --without-mailutils --without-selinux --with-gnutls --without-libsystemd --with-threads --without-wide-int --with-zlib --with-sound=alsa --with-x --without-ns --without-gconf --without-gsettings --without-toolkit-scroll-bars --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xpm --with-imagemagick --with-xft --with-cairo --without-harfbuzz --without-libotf --without-m17n-flt --with-x-toolkit=lucid --with-xaw3d Regards, Ihor --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=widget-ignore-pixelwise-3.patch diff --git a/src/widget.c b/src/widget.c index e8eaf0fadf..f92baa2cef 100644 --- a/src/widget.c +++ b/src/widget.c @@ -268,12 +268,8 @@ set_frame_size (EmacsFrame ew) if (! XtIsSubclass (wmshell, shellWidgetClass)) emacs_abort (); char_to_pixel_size (ew, w, h, &pixel_width, &pixel_height); - ew->core.width = (frame_resize_pixelwise - ? FRAME_PIXEL_WIDTH (f) - : pixel_width); - ew->core.height = (frame_resize_pixelwise - ? FRAME_PIXEL_HEIGHT (f) - : pixel_height); + ew->core.width = (pixel_width); + ew->core.height = (pixel_height); frame_size_history_add (f, Qset_frame_size, FRAME_TEXT_WIDTH (f), FRAME_TEXT_HEIGHT (f), @@ -315,8 +311,8 @@ update_wm_hints (EmacsFrame ew) XtVaSetValues (wmshell, XtNbaseWidth, (XtArgVal) base_width, XtNbaseHeight, (XtArgVal) base_height, - XtNwidthInc, (XtArgVal) (frame_resize_pixelwise ? 1 : cw), - XtNheightInc, (XtArgVal) (frame_resize_pixelwise ? 1 : ch), + XtNwidthInc, (XtArgVal) (cw), + XtNheightInc, (XtArgVal) (ch), XtNminWidth, (XtArgVal) base_width, XtNminHeight, (XtArgVal) base_height, NULL); --=-=-= Content-Type: text/plain martin rudalics writes: > > Oh. I meant maximised, not full screen. Initially, I observed the issue > > with maximised emacs frames. (My title bar is located at the bottom of > > the frame, not on top). > > I see it, now. The following is a bit tedious: Couldy you try in > widget.c and xterm.c to selectively make frame_resize_pixelwise have > no effect, so we could possibly locate the direct source of the > problem? There are four instances of this, three in widget.c and one > in xterm.c. For example, for the latter, you would have to change the > two lines > > size_hints.width_inc = frame_resize_pixelwise ? 1 : FRAME_COLUMN_WIDTH (f); > size_hints.height_inc = frame_resize_pixelwise ? 1 : FRAME_LINE_HEIGHT (f); > > in x_wm_set_size_hint in xterm.c to > > size_hints.width_inc = FRAME_COLUMN_WIDTH (f); > size_hints.height_inc = FRAME_LINE_HEIGHT (f); > > Thanks, martin --=-=-=--