From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#39546: 28.0.50; Do not require subr-x at run time Date: Mon, 10 Feb 2020 21:49:18 +0100 Message-ID: <87d0amyxpt.fsf@gmail.com> References: <87k14uwnjl.fsf@gmail.com> <831rr2cvci.fsf@gnu.org> <83r1z2bau6.fsf@gnu.org> <57dc180c-4b60-462c-88c2-9a6f97c191df@beta.fastmail.com> <87ftfiyye1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="87180"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39546@debbugs.gnu.org, michael.albinus@gmx.de, larsi@gnus.org To: "Tassilo Horn" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 10 21:50:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1G0W-000MYL-At for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 21:50:16 +0100 Original-Received: from localhost ([::1]:38568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1G0V-0003lI-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 15:50:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53624) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1G0J-0003ku-Sc for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:50:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1G0I-0008EV-RW for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1G0I-0008DJ-Ky for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1G0I-0003ci-Fx for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 15:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2020 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39546-submit@debbugs.gnu.org id=B39546.158136776713882 (code B ref 39546); Mon, 10 Feb 2020 20:50:02 +0000 Original-Received: (at 39546) by debbugs.gnu.org; 10 Feb 2020 20:49:27 +0000 Original-Received: from localhost ([127.0.0.1]:55516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1Fzi-0003bp-Pm for submit@debbugs.gnu.org; Mon, 10 Feb 2020 15:49:26 -0500 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:42061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1Fzh-0003bc-I2 for 39546@debbugs.gnu.org; Mon, 10 Feb 2020 15:49:26 -0500 Original-Received: by mail-wr1-f68.google.com with SMTP id k11so9477135wrd.9 for <39546@debbugs.gnu.org>; Mon, 10 Feb 2020 12:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BTSbQMBETts8g4pWYahzUrJsvqRLX+Nu1R6MEBrVUV8=; b=cbmRAzf8fP3Y5s/zy1ELaOXU2YZ6ZapBsYXp2D0LNZzCtZNMOHvNemf+gH1eTNTVDg kRM7NOCX0/ZlKCbCNTk1tovGAqGFf1TN5f0qUG3ZQ/xb+hIlUhxLtbd4Bz5D2rOXOn6g 3Ub4BwHNGa/mYCmUFGzGA8ZPYBHkUH7ybURCA4Vor/n3jaE+pM4ES4AnEeMTmyiLXolV U0dY0HOWXyW1lLUCwbdSws2XHg9Lf4gbe1cDeU3xy2fPMIbOTDORA6Qr7hy2Epkd0z50 j8uoHH0gwMgvi/HW+Fg2dHqSe2rSg9KxQredOEhYsFF4wqLdlJ5KYANVNEX7t0Hg9b40 BGJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BTSbQMBETts8g4pWYahzUrJsvqRLX+Nu1R6MEBrVUV8=; b=TNsaXS2+2MA/5jH20DLlL0HYqqKbEyizWzY2gP83aLQ3phRTOZZhBYAO4F2tMqQvVL p8bc3BCCJjMkjyjR1EnfnNjVbDpLUbLmAaZ/O8eUIMKA0ywC5CNhjSDcc4UPJ5nnB86p l5BZVNTqKi4du2E5Vib8XzJqRXAfT1M1I7MaQYW3Ueh7xth9QR0vHI+6UWiMT90i1yCR g7stXg7vx6k2tduXpBP3ikYHYRh9wQO+VDEuz8nXeZeMsA0+6YtUV1VnJwFdhQ6Kp6JA yvaJDz9lPo/OcatPWOPixgRMAczAo6GLuMmGZi36GMr/2W6T9T4EP2y+pZo+h18X+P6N Hk3Q== X-Gm-Message-State: APjAAAW/dRoh8ykt+qZJDyaADQ9N+/qIc/Xh8oosAhg1om/9V2uD3ld7 3mb/5jYUl9j6ARXKsctsvDo= X-Google-Smtp-Source: APXvYqyk+0HrtG9Wwnp+nFk95s63gtoAgrRJHNbei7ofwslDTikOkyVCDsDO3O0VvTJxWIn/mzTuuA== X-Received: by 2002:a5d:4dc5:: with SMTP id f5mr3975564wru.114.1581367759625; Mon, 10 Feb 2020 12:49:19 -0800 (PST) Original-Received: from localhost.example.com ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id f11sm680971wml.3.2020.02.10.12.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2020 12:49:19 -0800 (PST) In-Reply-To: <87ftfiyye1.fsf@gmail.com> (Tino Calancha's message of "Mon, 10 Feb 2020 21:34:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175904 Archived-At: Tino Calancha writes: > "Tassilo Horn" writes: > >> Am Mo, 10. Feb 2020, um 20:30, schrieb Tino Calancha: >>> replace.el is a good agreement between subr-x.el (it's a defun, so >>> it doesn't fit well there) and subr.el. >>> >>> As subr.el, replace.el is also loaded at start time, but it's ~ half size, >>> and more important than that, it's all about replacing in Emacs. >> >> Sounds good to me! > > Here is the updated patch: > - It deletes the cookie from subr-x (yes, we have one for when-let) > - Move replace-region-contents inside replace.el (loaded at startup) > - Add all required (eval-when...(req.. 'subr-x)) at tramp files > - Replaced loading subr-x at run time with compile time for some other files > > I have run the testsuite without surprises. Well, actually there was a surprise, but who don't like surprises after all! I missed this one (it was relying on the whe-let cookie): diff --git a/lisp/image/exif.el b/lisp/image/exif.el index 642bc58321..27ad616146 100644 --- a/lisp/image/exif.el +++ b/lisp/image/exif.el @@ -62,6 +62,7 @@ ;;; Code: (require 'cl-lib) +(eval-when-compile (require 'subr-x)) (defvar exif-tag-alist '((11 processing-software)