From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Sun, 19 Apr 2020 01:33:55 +0100 Message-ID: <87d084jouk.fsf@tcd.ie> References: <87o8roxu9r.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18651"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ivan Andrus , 40693@debbugs.gnu.org, Dmitry Gutov To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 19 02:36:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPxwi-0004lv-Bc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Apr 2020 02:36:28 +0200 Original-Received: from localhost ([::1]:34910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPxwh-0006ne-0Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 20:36:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40232) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPxwE-0006lA-IQ for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 20:36:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jPxvK-0001Z4-DO for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 20:35:58 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jPxvJ-0001Xu-Tx for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 20:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPxvJ-0001Qh-OT for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 20:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Apr 2020 00:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.15872564455405 (code B ref 40693); Sun, 19 Apr 2020 00:35:01 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 19 Apr 2020 00:34:05 +0000 Original-Received: from localhost ([127.0.0.1]:43815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPxuP-0001P6-5o for submit@debbugs.gnu.org; Sat, 18 Apr 2020 20:34:05 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:34723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPxuN-0001Oc-9R for 40693@debbugs.gnu.org; Sat, 18 Apr 2020 20:34:03 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id j1so2137904wrt.1 for <40693@debbugs.gnu.org>; Sat, 18 Apr 2020 17:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=D+uPPYsxWjqrJr6wo0Q3egPN2QbimRN1JvrHWgG7ZKA=; b=GqRuscVdHCayItVbxfSBrS7LCl8lTmt8ik4xeqs92WKO+zJful+BSdAxBMdUtxMxYx A7euvFKFQMkWmUdIEIpgN9gXMwZLk7YIRbRZ4tG71aaYZyL9eklfioDAkJNoQ6UlNmoe apFj0mLhMeRhq83PfyUBgFasnPUM9H5rRSpqZMMZCpXoMyMzY3n1TXCCCE4H6pw6Cw0l wg8wzyY2ltESletkBR7z/SeufWHZndSei+iW91NHdbpI+TyNjvVul2QQdHCDV9VFPBFU H8UUX9E3r7VWrW5ZIycbYOf1/ZYklEjo08xESi0BjnhS0hHJxo3t/7yMnjyCkupk8TWu Y3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=D+uPPYsxWjqrJr6wo0Q3egPN2QbimRN1JvrHWgG7ZKA=; b=W/BToLDEL1uQ3WUJhsim8rpGlK5u2Bt6kcqiFaK/akdtnoPWDFOwbYzup51Zk2I3Og S3H918fLeTIDgFqL+xLyevQIPbIeP9HNI21KgGcoIrVK1F/2BYv/dmIYU5lMMQk9CM04 TS6D/9ZZxTEcuadT7stgKd+U2urt0tfjeGpnb/MzAc3VpZOmfXxhwshA3bKIiyV1VoYP Y6IksZPmavhgzGYzlzLQFlALIlVso8UPujep+NSH9bQPGYVeJMbY9uELmvZLILRmOBaS kJjc9zqUFYtOlVDdovI8Mjoq1CX66dfMJdGtMfz2W9HGa7bduqhFM3Zxfo5L1IHjj8He We0Q== X-Gm-Message-State: AGi0PuZR1fqRis4UUVgCV1/rVJyiFNEu43zmOyh+5ouFc5oZYMbi2FTr 0XyMWzoFbBYa/KgnNng/AWC3fw== X-Google-Smtp-Source: APiQypKS62G2g2L/X5zusjV68bRldkG+IJ1Uc2SeualFCq6cKjGI0bK8CxsWvocVLlB7WKwX2DojjQ== X-Received: by 2002:adf:fe0e:: with SMTP id n14mr11998887wrr.247.1587256437418; Sat, 18 Apr 2020 17:33:57 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id l5sm38058167wrm.66.2020.04.18.17.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2020 17:33:56 -0700 (PDT) In-Reply-To: <87o8roxu9r.fsf@web.de> (Michael Heerdegen's message of "Sun, 19 Apr 2020 01:13:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178614 Archived-At: Michael Heerdegen writes: > Why? Isn't this a classical example of modifiable code? After some > iterations > > (symbol-function 'fun-withdraw) > > => > > (closure > (t) > (amount) > (json-encode-alist > (cons > (cons 'tamount amount) > '((const . some-constant) > (tamount . 12) > (tamount . 12) > (tamount . 12))))) > > So the problem is in the implementation of `fun-withdraw', not in that > of `json-encode-alist' or `sort'. > > I mean, it's really an example of an ugly trap, but how is > `json-encode-alist' different from other functions working with lists > that would exploit the same problem? A library function that encodes arbitrary Elisp objects as JSON shouldn't destructively modify its argument; it should be possible to call json-encode on the same object twice and get the same result. -- Basil