From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Date: Sat, 23 May 2020 21:54:14 +0200 Message-ID: <87d06umnq1.fsf@gmail.com> References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14071"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41372@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 23 21:55:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcaEe-0003dn-Qs for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 21:55:08 +0200 Original-Received: from localhost ([::1]:33954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcaEd-0003l3-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 15:55:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcaEX-0003kv-UM for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 15:55:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcaEX-0006SO-Kw for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 15:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcaEX-0001dm-Kb for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 15:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2020 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41372-submit@debbugs.gnu.org id=B41372.15902636666262 (code B ref 41372); Sat, 23 May 2020 19:55:01 +0000 Original-Received: (at 41372) by debbugs.gnu.org; 23 May 2020 19:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:35762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcaDx-0001cw-TY for submit@debbugs.gnu.org; Sat, 23 May 2020 15:54:26 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:35263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcaDv-0001ci-N6 for 41372@debbugs.gnu.org; Sat, 23 May 2020 15:54:24 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id n5so13274040wmd.0 for <41372@debbugs.gnu.org>; Sat, 23 May 2020 12:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7PQNpft+QIYDSnYI+Nc7/6CSEGXwQdCkPsjU9ab3xso=; b=bGWfq9X1ZsTYIaLcxRSn5BNJM1cHnXrBtWct23GM8+RoNUS69hwTLDE60x1G5yivhW JPcUHDP974MpBgy7D6mXCmRBxLiHQ6iZ6SZhLABz3JQESbuIUHhhBg82jPZHiT9Ga7BI eqj0a1qqv2mxSpVPEf7XoMe55TsxyCtZGNlIcElc/UR9ONm93WLYScT0hvnlM3aXS9nU ciuJoSTGOZsdFUq6ePVqKbkxXOJMFRdPfgpSOu3hc1jOELAHL/nQ7jt0sD9LqefBZmtX uuqC03Dx6/wUKgpCrWByvowJwsvHXqDxJu6CUvg2NaTKLrshD957V5xDuYjOBaWJ+8X7 8G8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7PQNpft+QIYDSnYI+Nc7/6CSEGXwQdCkPsjU9ab3xso=; b=EXNrS5ycwHvbXE0H5d3GRa5qORERN0W+f+hGHWVobGUvBnmWRERZRUTY7SpK1QGX+A ANHOQ4eUdBBRSr0RynM2MT1rhXZuqBqB8UResfnif1FT7lSgWk+xKVa3nxwrhAShWkz0 CeJ0j7JupNTuhr3WsCStWt7J9elQq6pxTgYBqgH30wr2lMXa3P7OaYdOETScdNR0ebt/ AjRTy5Qe+y2V9IqglB3kN/5kjjxP+7uojknfW3d2LtHOX4pu/aN7/Huj/D2QC1GyKunV ezu0s16e/0hHxbG9hv9aozYB44DrUNJSmyxUv8tekBI0hijYqQ0OZi1NFE16rvblYNSX tbUA== X-Gm-Message-State: AOAM532x2udjN2N4q5nSknU1W1o71oq2TR7k8Rbn5zDnISuYHY/2MGRV ShtXIKSU3hOCakRDubNe6Lecx3ZNigM= X-Google-Smtp-Source: ABdhPJx3jL0LMCqI3J+GTuCP59UuUGklvdCGP1Ipxx2yBRBWjfo/fWg60+P4NcZFzWb3MHECSwMCwA== X-Received: by 2002:a05:600c:214:: with SMTP id 20mr17857126wmi.41.1590263657490; Sat, 23 May 2020 12:54:17 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:252:7910:679d:a1d5:8917:cc97]) by smtp.gmail.com with ESMTPSA id w10sm1875042wrp.16.2020.05.23.12.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 12:54:16 -0700 (PDT) In-Reply-To: <87tv0b7dtf.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 20 May 2020 01:35:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180845 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Juri Linkov writes: > Thanks for the patch. One problem is that the patch hard-codes=20 > the ellipsis, so that the user loses the ability to configure=20 > it.=20 >=20 > A better way would be to leave defvar tab-bar-tab-name-ellipsis,=20 > but by default set its value to nil. So when it's non-nil, then=20 > use its value, otherwise use "=E2=80=A6"/"..." by default. You're right. Here's un updated patch: --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-Fix-tab-bar-tab-name-ellipsis-initialization.patch Content-Transfer-Encoding: quoted-printable >From d607000155a21340aebd101ee5dc4a12037088d7 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Mon, 18 May 2020 00:32:47 +0200 Subject: [PATCH] Fix tab-bar-tab-name-ellipsis initialization * lisp/tab-bar.el (tab-bar-tab-name-truncated): Evaluate displayable character when generating tab name. --- lisp/tab-bar.el | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index ce6d8c33dd..d24d59cb7e 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -376,19 +376,22 @@ tab-bar-tab-name-truncated-max :group 'tab-bar :version "27.1") =20 -(defvar tab-bar-tab-name-ellipsis - (if (char-displayable-p ?=E2=80=A6) "=E2=80=A6" "...")) +(defvar tab-bar-tab-name-ellipsis nil) =20 (defun tab-bar-tab-name-truncated () "Generate tab name from the buffer of the selected window. Truncate it to the length specified by `tab-bar-tab-name-truncated-max'. Append ellipsis `tab-bar-tab-name-ellipsis' in this case." - (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= )))) + (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= ))) + (ellipsis (cond + (tab-bar-tab-name-ellipsis) + ((char-displayable-p ?=E2=80=A6) "=E2=80=A6") + ("...")))) (if (< (length tab-name) tab-bar-tab-name-truncated-max) tab-name (propertize (truncate-string-to-width tab-name tab-bar-tab-name-truncated-max nil nil - tab-bar-tab-name-ellipsis) + ellipsis) 'help-echo tab-name)))) =20 --=20 2.20.1 --=-=-= Content-Type: text/plain; format=flowed -- Matthias --=-=-=--