From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil Date: Sun, 19 Jul 2020 17:20:08 +0200 Message-ID: <87d04rpm53.fsf__18655.0690837734$1595172091$gmane$org@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27916"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: bug#38421 <38421@debbugs.gnu.org> To: emacs-devel@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 19 17:21:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB82-00079r-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 17:21:26 +0200 Original-Received: from localhost ([::1]:36522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxB82-0004UZ-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 11:21:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxB7e-0004Lt-6k for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxB7d-0002I1-TI for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxB7d-0000y0-PZ for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2020 15:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38421 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38421-submit@debbugs.gnu.org id=B38421.15951720243638 (code B ref 38421); Sun, 19 Jul 2020 15:21:01 +0000 Original-Received: (at 38421) by debbugs.gnu.org; 19 Jul 2020 15:20:24 +0000 Original-Received: from localhost ([127.0.0.1]:61000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxB72-0000wc-Ci for submit@debbugs.gnu.org; Sun, 19 Jul 2020 11:20:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxB6z-0000wJ-8k for 38421@debbugs.gnu.org; Sun, 19 Jul 2020 11:20:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vwvb9HfzbqBm/g0gLSvc26qH827TJzwISbxti5z/sJk=; b=a7o9a0I7ABd7qZE2aRx9RoKa1Z GnBLpGodEAaiiyJGUYnDcdk5LRL/5w7mocyUitktouq/QHLSeT4wlkGCVy9SURIRfDPjzUhn9mQan HU/3skxa2nbgVYRzCR0Q3IQ0y4PtHocFdi+8eygsiNUNzhcVZRVTVJMmYjawSEvy82VQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB6n-0007FE-W4; Sun, 19 Jul 2020 17:20:15 +0200 In-Reply-To: (Filipp Gunbin's message of "Tue, 17 Dec 2019 15:55:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183234 Archived-At: Filipp Gunbin writes: > Could someone please review the patch? (bug#38421) > > It's simple, but I'm not sure about using gnus-visual-p in mm-* files. I don't think we can use that function there, because these are general utility functions (used by mh-e, for instance). As the comment in mm-view.el says: ;; Shouldn't these functions check whether the user even wants to use ;; font-lock? They should, indeed. But I'm not quite sure what the correct approach for the application (that is Gnus) to inhibit these functions... What functions to use is decided by mm-inline-media-tests, and there's no way to use one version if we want highlights and another if we don't... Anybody got any ideas here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no