From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24427: 25.1.50; end-of-defun jumps too far Date: Tue, 11 Aug 2020 16:03:20 +0200 Message-ID: <87d03xuvo7.fsf@gnus.org> References: <87fup4q7ut.fsf@mbork.pl> <87d1k7a6lo.fsf@cochranmail.com> <8760pza6g2.fsf@cochranmail.com> <871t0etod0.fsf@cochranmail.com> <87twd9vxaj.fsf@mbork.pl> <87r38cw7bp.fsf@mbork.pl> <8737kftjv5.fsf@cochranmail.com> <87bmc9ti8l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31340"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Robert Cochran , 24427@debbugs.gnu.org, Marcin Borkowski To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 11 16:04:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Ut2-00080s-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 16:04:20 +0200 Original-Received: from localhost ([::1]:49996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Ut0-0007QM-QR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 10:04:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Usk-0007Q4-BO for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Usk-0008KN-2I for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5Usj-0004pA-S1 for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24427-submit@debbugs.gnu.org id=B24427.159715461518494 (code B ref 24427); Tue, 11 Aug 2020 14:04:01 +0000 Original-Received: (at 24427) by debbugs.gnu.org; 11 Aug 2020 14:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:41274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5UsJ-0004oD-0s for submit@debbugs.gnu.org; Tue, 11 Aug 2020 10:03:35 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:32810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5UsH-0004nx-Gw for 24427@debbugs.gnu.org; Tue, 11 Aug 2020 10:03:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NmptWPxSKFif5/VKSF35mTkWLAJ5QwStL0hNQZst1vU=; b=KI2sUGQA9yEqhhBPicX5jbGF6D I5WYy3g2ezCxxn4dIS+2dMesTTyxAFIcs/QVKSwu9s19JnJrHM9NdYwU7HYdShoE1uH08M2DbVsf8 VLaAoupQ0KEJaaCwSF3EAQexYGRj23AsW72EdpNU5N4wj3LEy3gGL+1Hg5OJdWdMtJsE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Us6-00040t-FK; Tue, 11 Aug 2020 16:03:26 +0200 In-Reply-To: <87bmc9ti8l.fsf@gmail.com> (Noam Postavsky's message of "Sun, 17 Jun 2018 13:50:34 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184653 Archived-At: Noam Postavsky writes: > Not entirely sure if this is correct, but the patch below seems to fix > it for me, without breaking any of the previously mentioned scenarios. > I find the fact that end-of-defun goes to the line following the closing > paren a bit dubious, though I guess since it's been that way so long, we > can hardly change it now. [...] > * lisp/emacs-lisp/lisp.el (end-of-defun): Only skip to next line when > after end of defun when ARG is 1 or less. > * test/lisp/emacs-lisp/lisp-tests.el (end-of-defun-twice): New test. There was no followup on this. I tested the patch, and it seems to work for me. (There's no test failures in "make check" either.) So I just went ahead and pushed the fix to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no