From: Lars Ingebrigtsen <larsi@gnus.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Robert Cochran <robert-emacs@cochranmail.com>,
24427@debbugs.gnu.org, Marcin Borkowski <mbork@mbork.pl>
Subject: bug#24427: 25.1.50; end-of-defun jumps too far
Date: Tue, 11 Aug 2020 16:03:20 +0200 [thread overview]
Message-ID: <87d03xuvo7.fsf@gnus.org> (raw)
In-Reply-To: <87bmc9ti8l.fsf@gmail.com> (Noam Postavsky's message of "Sun, 17 Jun 2018 13:50:34 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> Not entirely sure if this is correct, but the patch below seems to fix
> it for me, without breaking any of the previously mentioned scenarios.
> I find the fact that end-of-defun goes to the line following the closing
> paren a bit dubious, though I guess since it's been that way so long, we
> can hardly change it now.
[...]
> * lisp/emacs-lisp/lisp.el (end-of-defun): Only skip to next line when
> after end of defun when ARG is 1 or less.
> * test/lisp/emacs-lisp/lisp-tests.el (end-of-defun-twice): New test.
There was no followup on this. I tested the patch, and it seems to work
for me. (There's no test failures in "make check" either.)
So I just went ahead and pushed the fix to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-11 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 12:53 bug#24427: 25.1.50; end-of-defun jumps too far Marcin Borkowski
2016-09-13 20:26 ` Robert Cochran
2016-09-13 20:30 ` Robert Cochran
2016-09-20 18:31 ` Robert Cochran
2016-09-21 19:59 ` Marcin Borkowski
2016-09-22 10:35 ` Marcin Borkowski
2016-10-02 5:12 ` Robert Cochran
2018-06-17 17:50 ` Noam Postavsky
2020-08-11 14:03 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d03xuvo7.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24427@debbugs.gnu.org \
--cc=mbork@mbork.pl \
--cc=npostavs@gmail.com \
--cc=robert-emacs@cochranmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).