unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39408@debbugs.gnu.org, Timo Lilja <timo.lilja@iki.fi>
Subject: bug#39408: Breakpoints don't work with M-x gdb under TRAMP
Date: Fri, 21 Aug 2020 16:08:35 +0200	[thread overview]
Message-ID: <87d03khz18.fsf@gmx.de> (raw)
In-Reply-To: <87mu2o6wzn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 13:48:12 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

> Michael, there's tramp-related patch for gdb-mi/gud in this bug report
> that I think looks reasonable, if I'm reading it correctly.  Do you have
> any opinions on this?

Somehow, I've missed that bug report :-(

I have no objection to apply the patch, but wouldn't it be better to
understand, why bindat-get-field returns file names like
/ssh:vagrant@debug:/vagrant/"/vagrant/hello.c" ? Just patching the
obscure result doesn't look error prone to me.

Furthermore,

-  (setq f (concat (or (file-remote-p default-directory) "") f))
+  (unless (file-remote-p f)
+    (setq f (concat (or (file-remote-p default-directory) "") f)))

could be simplified to

   (setq f (concat (file-remote-p default-directory) f))

Best regards, Michael.





  reply	other threads:[~2020-08-21 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 19:07 bug#39408: Breakpoints don't work with M-x gdb under TRAMP Timo Lilja
2020-08-21 11:48 ` Lars Ingebrigtsen
2020-08-21 14:08   ` Michael Albinus [this message]
2021-04-16  5:02 ` Jim Porter
2021-05-01  9:59   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d03khz18.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=39408@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=timo.lilja@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).