From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6542: bug#17954: 24.4.50; [patch] `menu-bar-make-toggle' should allow for keywords Date: Sat, 19 Sep 2020 18:24:37 +0200 Message-ID: <87d02hohtm.fsf@gnus.org> References: <9e5b6c5f-0dd9-44ef-b997-3cc032e7a107@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13428"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 17954@debbugs.gnu.org, 6542@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 18:48:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJg2Y-0003Nx-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 18:48:46 +0200 Original-Received: from localhost ([::1]:33342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJg2X-0000QA-3Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 12:48:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJffb-00032c-Hx for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 12:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJffb-0001e9-7r for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 12:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJffb-0006QK-4B for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 12:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 16:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6542 X-GNU-PR-Package: emacs Original-Received: via spool by 6542-submit@debbugs.gnu.org id=B6542.160053269024638 (code B ref 6542); Sat, 19 Sep 2020 16:25:03 +0000 Original-Received: (at 6542) by debbugs.gnu.org; 19 Sep 2020 16:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:47892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJffO-0006PJ-8p for submit@debbugs.gnu.org; Sat, 19 Sep 2020 12:24:50 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJffL-0006Ox-Rl; Sat, 19 Sep 2020 12:24:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DUNA5xdT2owhjmCW4btT8Mg+bODK/UxkLp1dvvtLVP4=; b=bbtwZzgd6rfSRPkVl0dwV6VjS8 5UA05VN9yatSGsJJ43n6Z9YD+9V4LBIxlX6xoEvf7i7i2fK6EjmKtDaLTcavvQe+756iRnEJLGu7A AfzkP1/orrAJjhQ3IwGh3nxE6Td5ifyXFQvBGAwL+cI9i7mz6djlR6qFoejIhQNB4lTI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJffC-0000It-ME; Sat, 19 Sep 2020 18:24:41 +0200 X-Now-Playing: Frankie Goes To Hollywood's _Welcome To The Pleasuredome_: "War" In-Reply-To: <9e5b6c5f-0dd9-44ef-b997-3cc032e7a107@default> (Drew Adams's message of "Sat, 5 Jul 2014 22:28:37 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188407 Archived-At: Drew Adams writes: > `menu-bar-make-toggle' handles no keywords. It takes the value of > :help as an explicit argument (without keyword), but it does not pass > along :keys, :active, :enable, etc. to `menu-item'. It should. > > It cannot accept keywords in the normal way because it defines BODY as > an &rest parameter. This mistake should be corrected, making for an > incompatible change unfortunately, in order to allow a KEYWORDS &rest > parameter. > > BODY is seldom used. In the Emacs Lisp sources, there are only these > two occurrences of `menu-bar-make-toggle' that use BODY: > `toggle-save-place-globally' and `toggle-uniquify-buffer-names'. They > would just need to wrap the current BODY code in an explicit `progn'. I've now applied your patch, but renamed the resulting macro to menu-bar-make-toggle-command, while the former name is now an obsolete wrapper macro. I've also adjusted all in-tree callers. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no