From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulf Jasper Newsgroups: gmane.emacs.bugs Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Date: Thu, 01 Oct 2020 18:19:29 +0200 Message-ID: <87d021vrzi.fsf@panama> References: <23640.9851.562972.730234@AGAME7.local> <875ztog7hx.fsf@panama> <87wom1otsw.fsf@panama> <87zh7267sy.fsf@gnus.org> <87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@gnu.org> <24369.32256.954408.774614@AGAME7.local> <87y2mlxx8r.fsf@gnus.org> <87d03x43kz.fsf@panama> <24371.59842.984273.402129@AGAME7.local> <87y2mkknyc.fsf@gnus.org> <24371.61149.995030.284670@AGAME7.local> <87364rq4yl.fsf@panama> <87imcwf404.fsf@panama> <24400.43911.666145.400179@AGAME7.local> <874kof2aui.fsf@panama> <24435.1743.473339.944597@AGAME7.local> <874knewwfc.fsf@gnus.org> <24437.56299.111042.412318@AGAME7.local> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4840"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Lars Ingebrigtsen , 34315@debbugs.gnu.org, Jan Tatarik To: thunk2@arcor.de (Thomas Plass) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 18:28:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO1Rf-000192-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 18:28:39 +0200 Original-Received: from localhost ([::1]:40994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO1Re-00061v-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 12:28:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO1JM-0004rf-2U for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 12:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO1JK-0001vA-Fi for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 12:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO1JK-0006TJ-BB for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 12:20:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <23640.9851.562972.730234@AGAME7.local> Resent-From: Ulf Jasper Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34315-submit@debbugs.gnu.org id=B34315.160156918524850 (code B ref 34315); Thu, 01 Oct 2020 16:20:02 +0000 Original-Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 16:19:45 +0000 Original-Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO1J2-0006Sj-9x for submit@debbugs.gnu.org; Thu, 01 Oct 2020 12:19:45 -0400 Original-Received: from mout.web.de ([212.227.17.12]:40811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO1Iz-0006SV-Tl for 34315@debbugs.gnu.org; Thu, 01 Oct 2020 12:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1601569173; bh=1vC1MjpGRHf2sBG9oVMYeGCklv0/LbOiuYsjrAlP3iM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=FYMEfUSlKpgAq3VRNiRISXQxzMFqksQSVaAFmXrU/TCFwKXwu1vwJb0s8jgZ5kJBP 0Z1pBcQcFUw0ypvawV6n/b03U/leHvMwxXUgZxgQFk4ZjV5Z7btKjc9mjJ2wiyU41B iUOjbIjoaT1bwK8Ed1oNGU1hwbeYJY24Pbx2j9uo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Md4pC-1k5wUJ16Xq-00ICKn; Thu, 01 Oct 2020 18:19:33 +0200 X-Provags-ID: V03:K1:+6nUcDKS2zwN4srFFYs81ObF9/SIT1njSe9yeS7RXJYXwlnrz9a ASUewUlViq8P9jkz7skuJyapOq3uLrKEE5H9FLvGTYoINdmOFhfCoqPFScWlxNwDND6eP+S hVIzM4bHdirt5/PJW7xbRmAYAWTvC60zytxWERdMIYLQ9x+T5/eIqrQ1fFEq0EjxFndCoyc cBMtwHcsJ03wT/7Gi17TQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:A6c3b9FU1/M=:kMdBlwM1M2Y0lm996rtNbm FbsiF32XnoiWw2Sl7yTRwMPBUWsLED2FIJvD3jf3WYIXiDjveZ84XRjGSvuNCnfnFquJiY80B Pc2q7UkMIu/9jwqGqylbkbTDcNo19TMa3wYXDizxM/DSxegLGDTigMcKqWZ/UZu6bWJAO38Ji VAhAUTM8pVfPpHeP3ydK2IinsI6k1aL2jpP/a9Gx88MvfzNA5p70vTzcDN0vqmwf+q0vPhCQL AywAIoxKxRd4SzSbq/briEhPWykn/1GrQwYuEYN4jJ0S//X7IcPN2UfgJDoEIR0bJH3Dtfyi5 Zo9GVmEYX1cAcPg8qhvB6/QYOiNEEKh7yk8qCX9/7grWLOpFg2Lz9wDd5VnaVD3+L/W9s9UEd ZrfSHUE4uvB6m5ofR707crMU9pw5HrzpTjOQjGEGkK1/iWeFJTLljhmrzkHYsxA+aV/AaNoqQ fCoQtg+LGO/105qzDqeUcxwaht7+J1nLXwMRZxiNoLDMJZ8YQgKuuXK0AMU/usf92V9nc0n+P HHaoW2wghbCzi8sfBY4hvt+O0W+yYpp0M1gAGDgNrRyznDABhoMeRntJVpE62sPK83hXnp/1S 54dWXOcrPJj2dOKdu8wqYzMaAPF4bC9zRlbB2EYpueNcHBGKkGnf25xaZtDwvylVpPgyiANTM iJ4iSzm8OC5veqNMZVLzd6ujwN1/DTPoLRBBpQTDUWHkmJIkjWx0rCz6EsffG6uP6K43TcZoA ocNQjcaTZ5VDrDwkTgIGbU9YJCsDiEIQhxnH9uERwve8W4fHyljXiDa/2FsMRwcZJOix3JD4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189529 Archived-At: Am 01.10.2020 um 16:38 (+0300) schrieb Thomas Plass: > But I'd rather let Ulf have the final say about the patches and how > the data is to be tested. I agree with Lars here. (Thank you, Lars, for your investigation!) When patching icalendar.el (or any other file) one must make sure that the corresponding unit tests do not fail. If necessary the unit tests need to be adjusted. If possible one should add unit tests so that all code changes get covered. (And so on -- the usual ideas behind unit tests.) It looks like your patch of 'icalendar-tests.el' does not contain the samples from the ics files. Could you please add these?