unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, Stephen Berman <stephen.berman@gmx.net>,
	44113@debbugs.gnu.org
Subject: bug#44113: 28.0.50; crash with cairo and Noto Sans Javanese font
Date: Thu, 22 Oct 2020 14:38:12 +0200	[thread overview]
Message-ID: <87d01ao2q3.fsf@gnus.org> (raw)
In-Reply-To: <83lffzmvxl.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Oct 2020 18:37:58 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Yes, let's install that patch (I guess on the emacs-27 branch?).

I installed it on master, but we should cherry-pick it for emacs-27 in a
couple of days (if there's no problems with it).

> However, there are more places in that function where we call APIs
> which could return NULL, and then dereference their return values
> without checking.  Could someone who can build with Cairo please
> install similar changes in those other places?

Robert said:

> All the other calls to cairo_ft_scaled_font_lock_face use the
> cr_scaled_font member of the font_info passed in, which I think means
> thatʼs only done for fonts which were opened successfully.

So I didn't check any further.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-10-22 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 10:12 bug#44113: 28.0.50; crash with cairo and Noto Sans Javanese font Stephen Berman
2020-10-21 12:22 ` Stephen Berman
2020-10-21 13:00   ` Robert Pluim
2020-10-21 13:25     ` Stephen Berman
2020-10-21 15:37       ` Eli Zaretskii
2020-10-22 12:38         ` Lars Ingebrigtsen [this message]
2020-11-07  8:15           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d01ao2q3.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=44113@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).