From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Thu, 29 Oct 2020 11:11:54 +0200 Organization: LINKOV.NET Message-ID: <87d011s8f9.fsf@mail.linkov.net> References: <87mu06p1aw.fsf_-_@mail.linkov.net> <9a425c29-56c5-90f4-ffbc-19bbd0643d03@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 44294@debbugs.gnu.org, Dmitry Gutov To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 29 10:14:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kY40a-000Abc-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 10:14:12 +0100 Original-Received: from localhost ([::1]:44310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY40Z-0001qU-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 05:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY40Q-0001nW-R1 for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 05:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kY40Q-0007RR-Hw for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 05:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kY40Q-0005wX-EZ for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Oct 2020 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.160396281422785 (code B ref 44294); Thu, 29 Oct 2020 09:14:02 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 29 Oct 2020 09:13:34 +0000 Original-Received: from localhost ([127.0.0.1]:51815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3zx-0005vR-LW for submit@debbugs.gnu.org; Thu, 29 Oct 2020 05:13:33 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3zn-0005uN-8I for 44294@debbugs.gnu.org; Thu, 29 Oct 2020 05:13:23 -0400 X-Originating-IP: 91.129.102.160 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B3340FF809; Thu, 29 Oct 2020 09:13:15 +0000 (UTC) In-Reply-To: (Philipp Stephani's message of "Thu, 29 Oct 2020 09:30:39 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191945 Archived-At: >> > - (user-error "Rerun etags: `%s' not found in %s" >> > - pat buffer-file-name))) >> > + (if (or (= (point-min) 1) (not widen-automatically)) >> >> Couldn't a buffer be narrowed, but point-min still be equal to 1? > > Yes, this should be (eql (buffer-size) (- (point-max) (point-min)). It's nice that you arrived to the same code that is used in the existing function buffer-narrowed-p (I missed it before).