From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions] Date: Fri, 30 Oct 2020 22:51:36 +0000 Message-ID: <87d00zxr7r.fsf@gmail.com> References: <2e610c3f-6e5f-c7dd-af2e-aeb5e20d8664@gmx.at> <3fa6b315-7fc0-06ee-81e9-b68d164aec1b@gmx.at> <87a6x7jf9a.fsf@gmail.com> <874knbi0jc.fsf_-_@gmail.com> <87362tggvl.fsf@gmail.com> <87d01vem7z.fsf@gmail.com> <17da3e99-d4fc-a603-baa3-4180d612af41@gmx.at> <878scie5ti.fsf@gmail.com> <87tuujr6sd.fsf@gmail.com> <803c87c2-7d60-5997-2247-85d3e62e3d2c@gmx.at> <87a6w7puuz.fsf@gmail.com> <64831acc-996e-51d7-ce6f-b667a6334e3c@gmx.at> <87imavo322.fsf@gmail.com> <878sbqwvyd.fsf@gnus.org> <87zh46n0af.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuan Fu , 43609-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 23:52:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYdG1-0008jE-2S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 23:52:29 +0100 Original-Received: from localhost ([::1]:35338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYdFz-0004zr-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 18:52:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYdFa-0004zg-Pm for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 18:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYdFa-0000yC-GU for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYdFa-00048u-El for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 18:52:02 -0400 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 22:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43609 X-GNU-PR-Package: emacs Mail-Followup-To: 43609@debbugs.gnu.org, joaotavora@gmail.com, rudalics@gmx.at Original-Received: via spool by 43609-done@debbugs.gnu.org id=D43609.160409830615896 (code D ref 43609); Fri, 30 Oct 2020 22:52:02 +0000 Original-Received: (at 43609-done) by debbugs.gnu.org; 30 Oct 2020 22:51:46 +0000 Original-Received: from localhost ([127.0.0.1]:60109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYdFK-00048K-BN for submit@debbugs.gnu.org; Fri, 30 Oct 2020 18:51:46 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:36016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYdFI-000487-IF for 43609-done@debbugs.gnu.org; Fri, 30 Oct 2020 18:51:45 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id x7so8095491wrl.3 for <43609-done@debbugs.gnu.org>; Fri, 30 Oct 2020 15:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=enC7yaiUd+Llu6P4yhO9XNy7Mlf9pcgazXHjqlJiajw=; b=JorOF5cUO7vwPgUFvxTd2n/TfKzcNXxRlj+fSd/AZbbm252mmw7vaEbWzrAjlHOhr9 Dn4IOAmQWHuyGeFrgdMzAx9L/j1bZz5O2EEnH+rsRR/y6p5nKCvKrpV5na1GjuJNgCn2 MQjafnfK1YDo7XsQGpTjq8WL4OjiFD3X7jzkehWhk1P+eYWa73nv7KEK1EMGLX1uxarB vh1p8ePFaG7nyyRfsuXvw6RL5hlDPrkaxTSQYDfclCpU1SU/kfLtJLrzwvdduNFCHEPR v4lvZQXWtrDZfEDo7IjJkDAaJJ4pJGHsYCXRkwtdpTrCk8BEv8HR4IPG9aF9SzpWzVlD pq4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=enC7yaiUd+Llu6P4yhO9XNy7Mlf9pcgazXHjqlJiajw=; b=cP4YnLso8BNJkGvhOzWDV7yd4Ap0kwyYv3bIvfoq0LNOkNHRHXhgm9uBN99fLzmxQg SuZbUEdDeY3JxqsgANtyhIqb74fHm3/emtFIOhIn9InxPUAuXSliKHCU7+EqVJtJ0CHp JeP4j+WjLKXO/XtDZFjVrMJiR9/Mo8GaMW/ArsCzTERCw1I8pRDUGfN2XGUytEmKqZ1i sz8LTEjdNb3/4GEeOk/1VIgjKw+6ZsY3VT/GbvbOo4offjySB1eKiN3dVmdNyggzEJ68 ANxj3tZcCr7xRwH5MVQLNFRbP2DAs7hlfb3rSjFMQo1WtsB/P77DP9USA630+yJfVp0z KIQA== X-Gm-Message-State: AOAM530C8goKLouhiHDh3qGYZdZORdmpy0xptZMAp6LrCpgLI4/eg6XE eD8Z8HXa5Gs3DDg2ecM/ZWw= X-Google-Smtp-Source: ABdhPJwiSwWYwZ3ETDLqBc5KWyvrI+SlgiL0zLXltdHF3AWB1jYsIvTXblNGjXu0yg5K9ocwxpUI1A== X-Received: by 2002:a5d:468f:: with SMTP id u15mr6014501wrq.154.1604098298693; Fri, 30 Oct 2020 15:51:38 -0700 (PDT) Original-Received: from krug ([89.180.149.55]) by smtp.gmail.com with ESMTPSA id m4sm12090780wrr.47.2020.10.30.15.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 15:51:37 -0700 (PDT) In-Reply-To: <87zh46n0af.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 28 Oct 2020 09:54:16 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192218 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Lars Ingebrigtsen writes: > >> Jo=C3=A3o T=C3=A1vora writes: >> >>> [Lars, I'm CC'ing you specifcally since there's a patch to review at the >>> end.] >> >> I don't really know much about eldoc, so I don't have much to say here... >> >> [...] >> >>> +(defalias 'elisp-eldoc-documentation-function 'elisp--documentation-on= e-liner >> >> [...] >> >>> +(make-obsolete 'elisp-eldoc-documentation-function >>> + "use ElDoc's interfaces instead." "28.1") >>> + >> >> But this seems like the correct approach -- we should never remove >> non-internal functions without going through the obsoletion process. >> (And "--" functions are the only ones that are clearly marked as >> internal; for internalish functions prior to that convention we have to >> do this for all of them, whether we consider them internal or not.) > > OK, I'm pushing that. I just did this. elisp-eldoc-documentation-function is now in master again. Martin, from what I understand of this bug, fixing your problem is now this short snippet away in your .emacs or in your martin-tooltip.el library: (add-hook 'emacs-lisp-mode-hook (lambda () (setq-local eldoc-documentation-function #'elisp-eldoc-documentation-function))) The byte-compiler should warn you that elisp-eldoc-documentation-function is obsoleted, but that's fine. I'm also closing this bug, I will of course re-open if you don't agree. Jo=C3=A3o