From: "João Távora" <joaotavora@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Yuan Fu <casouri@gmail.com>, 43609-done@debbugs.gnu.org
Subject: bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions]
Date: Fri, 30 Oct 2020 22:51:36 +0000 [thread overview]
Message-ID: <87d00zxr7r.fsf@gmail.com> (raw)
In-Reply-To: <87zh46n0af.fsf@gmail.com> ("João Távora"'s message of "Wed, 28 Oct 2020 09:54:16 +0000")
João Távora <joaotavora@gmail.com> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> João Távora <joaotavora@gmail.com> writes:
>>
>>> [Lars, I'm CC'ing you specifcally since there's a patch to review at the
>>> end.]
>>
>> I don't really know much about eldoc, so I don't have much to say here...
>>
>> [...]
>>
>>> +(defalias 'elisp-eldoc-documentation-function 'elisp--documentation-one-liner
>>
>> [...]
>>
>>> +(make-obsolete 'elisp-eldoc-documentation-function
>>> + "use ElDoc's interfaces instead." "28.1")
>>> +
>>
>> But this seems like the correct approach -- we should never remove
>> non-internal functions without going through the obsoletion process.
>> (And "--" functions are the only ones that are clearly marked as
>> internal; for internalish functions prior to that convention we have to
>> do this for all of them, whether we consider them internal or not.)
>
> OK, I'm pushing that.
I just did this. elisp-eldoc-documentation-function is now in master
again. Martin, from what I understand of this bug, fixing your problem
is now this short snippet away in your .emacs or in your
martin-tooltip.el library:
(add-hook 'emacs-lisp-mode-hook
(lambda () (setq-local eldoc-documentation-function
#'elisp-eldoc-documentation-function)))
The byte-compiler should warn you that
elisp-eldoc-documentation-function is obsoleted, but that's fine.
I'm also closing this bug, I will of course re-open if you don't agree.
João
next prev parent reply other threads:[~2020-10-30 22:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:46 bug#43609: 28.0.50; eldoc-documentation-function martin rudalics
2020-09-26 18:34 ` Dmitry Gutov
2020-09-27 8:30 ` martin rudalics
2020-09-29 11:20 ` Dmitry Gutov
2020-09-29 15:09 ` martin rudalics
2020-09-29 15:23 ` Dmitry Gutov
2020-09-30 8:14 ` martin rudalics
2020-09-30 8:50 ` Dmitry Gutov
2020-09-30 14:37 ` João Távora
2020-09-30 17:33 ` martin rudalics
2020-09-30 18:22 ` João Távora
2020-10-01 8:40 ` martin rudalics
2020-10-01 9:23 ` João Távora
2020-10-03 19:15 ` bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions] João Távora
2020-10-05 8:35 ` martin rudalics
2020-10-05 9:29 ` João Távora
2020-10-06 8:23 ` martin rudalics
2020-10-06 9:29 ` João Távora
2020-10-07 8:36 ` martin rudalics
2020-10-07 8:40 ` João Távora
2020-10-07 9:36 ` João Távora
2020-10-08 8:22 ` martin rudalics
2020-10-08 8:27 ` João Távora
2020-10-09 8:03 ` martin rudalics
2020-10-24 15:18 ` João Távora
2020-10-26 14:12 ` João Távora
2020-10-27 9:59 ` martin rudalics
2020-10-27 9:58 ` martin rudalics
2020-10-27 15:11 ` João Távora
2020-10-27 18:05 ` martin rudalics
2020-10-27 19:56 ` João Távora
2020-10-28 8:39 ` martin rudalics
2020-10-28 9:38 ` João Távora
2020-10-31 8:01 ` martin rudalics
2020-10-28 9:17 ` Lars Ingebrigtsen
2020-10-28 9:54 ` João Távora
2020-10-30 22:51 ` João Távora [this message]
2020-10-31 8:02 ` martin rudalics
2020-10-23 2:37 ` Yuan Fu
2020-10-24 17:09 ` João Távora
2020-10-31 13:07 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d00zxr7r.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=43609-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).