From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Fri, 11 Dec 2020 17:53:34 +0200 Message-ID: <87czzgbapt.fsf@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> <87ft4edret.fsf@protesilaos.com> <87zh2ldgtf.fsf@protesilaos.com> <87k0toof83.fsf@mail.linkov.net> <83wnxo1mcr.fsf@gnu.org> <83v9d81khh.fsf@gnu.org> <83mtyk1hq3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: contovob@tcd.ie, 45068@debbugs.gnu.org, Stefan Kangas , juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 16:54:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knkks-0008Du-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 16:54:50 +0100 Original-Received: from localhost ([::1]:60656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knkkr-000317-Di for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 10:54:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knkk7-00030S-4i for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 10:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knkk6-0007mj-8W for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 10:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knkk6-0002Ze-7M for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 10:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16077020419887 (code B ref 45068); Fri, 11 Dec 2020 15:54:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 11 Dec 2020 15:54:01 +0000 Original-Received: from localhost ([127.0.0.1]:42720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkjs-0002ZB-S0 for submit@debbugs.gnu.org; Fri, 11 Dec 2020 10:54:01 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkjr-0002Yl-Fj for 45068@debbugs.gnu.org; Fri, 11 Dec 2020 10:53:48 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E690DFF803; Fri, 11 Dec 2020 15:53:39 +0000 (UTC) In-Reply-To: <83mtyk1hq3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Dec 2020 17:32:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195779 Archived-At: On 2020-12-11, 17:32 +0200, Eli Zaretskii wrote: >> From: Stefan Kangas >> Date: Fri, 11 Dec 2020 09:15:32 -0600 >> Cc: juri@linkov.net, info@protesilaos.com, contovob@tcd.ie, >> 45068@debbugs.gnu.org >> >> > What theme-related files need to be byte-compiled, and why? >> >> I believe the issues involved are explained in some detail in the first >> message in this bug report. > > If they are, I'm missing that. All I see is an assertion that the > files must be byte-compiled: > >> The problem with contributing this new code to Emacs is that it cannot >> work if it is placed in ../etc/themes/. Instead, the files need to be >> in a path that handles byte-compilation, like ../lisp/modus-themes/. > > I'm probably missing something, and that is what I'm asking to > elaborate on. There now are four *.el files that make up the project: + modus-themes.el contains all defcustom, color palettes as alists, helper functions, and the face specs. + modus-themes-core.el contains a macro that 'let' binds the aforementioned alists around 'custom-theme-set-faces' and 'custom-theme-set-variables'. + modus-{operandi-vivendi}-theme.el contain a 'deftheme' and concomitant 'provide-theme' referencing each of them and just expand the macro. - Each of those files has (require 'modus-themes) and (eval-when-compile (require 'modus-themes-core)). Though I also tried without the eval-when-compile part. When I attempted to place all four files in etc/themes/ and then start a new 'emacs -Q' session, M-x load-theme RET modus-{operandi,vivendi} would throw an error: Cannot open load file: No such file or directory, modus-themes Whereas the latest patch I sent[1] does not produce any errors and fixes the issues I had identified in my original message. [1]: https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-12/msg00937.html -- Protesilaos Stavrou protesilaos.com