From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45686: 28.0.50; Could minibuf-eldef-setup-minibuffer inhibit modifications hooks, please? Date: Sun, 10 Jan 2021 15:43:25 +0100 Message-ID: <87czycsvhu.fsf@gnus.org> References: <86wnwqgbck.fsf@matem.unam.mx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45686@debbugs.gnu.org To: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 10 15:44:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kybxF-0005Mf-PB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 15:44:29 +0100 Original-Received: from localhost ([::1]:42160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kybxE-0004Tr-FD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 09:44:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kybwo-0004T1-Bi for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 09:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kybwo-0006J8-3M for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 09:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kybwo-0003QL-07 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 09:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45686 X-GNU-PR-Package: emacs Original-Received: via spool by 45686-submit@debbugs.gnu.org id=B45686.161028982513104 (code B ref 45686); Sun, 10 Jan 2021 14:44:01 +0000 Original-Received: (at 45686) by debbugs.gnu.org; 10 Jan 2021 14:43:45 +0000 Original-Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybwW-0003PI-Sx for submit@debbugs.gnu.org; Sun, 10 Jan 2021 09:43:45 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybwQ-0003Oq-4z for 45686@debbugs.gnu.org; Sun, 10 Jan 2021 09:43:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=APxZH3M8B6IfQFr5/kteHgS6Sbelg9qt77wBEgYI/Co=; b=hT/SJR6QLpDKe1OtjCzgIylJgv XK89ezH5UsvSeVHgK7zyZ3O21GsNrb1GXLipOSN8xnsTqShGQBeTbgKs3ykZlF9PLvyZCBuNKrFCg RD+/ILPEYl9jdpoD054my2z2uQuzIa/3ZN3zK38UgYAgf3R5rGgXxrAQH64F5/CApHdQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kybwE-0007rV-Of; Sun, 10 Jan 2021 15:43:30 +0100 X-Now-Playing: Joy Division's _Substance_: "Novelty" In-Reply-To: <86wnwqgbck.fsf@matem.unam.mx> ("Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena"'s message of "Tue, 05 Jan 2021 18:25:47 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197617 Archived-At: Omar Antol=C3=ADn Camarena writes: > I'd like it if minibuf-eldef-setup-minibuffer was wrapped in > > (let ((inhibit-modification-hooks t)) > ...) [...] > This works fabulously except if I use > > (setq minibuffer-eldef-shorten-default t) > (minibuffer-electric-default-mode) > > Because if the minibuffer prompt does have a default, and it gets > shortened, the shortening triggers after-change-functions even though > the user hasn't typed anything at the minibuffer. So that's why I want > minibuf-eldef-setup-minibuffer to inhibit modification hooks, but if > there's a reason it shouldn't or a better way to solve my problem, I > would love to hear it. Well, I could see others wanting to trigger something on these modifications, too, so I'm not sure inhibiting these specific modifications from running the hooks would be a good general solution. And as you say: > For now, I just add this to my configuration, so my problem is actually > solved already: > > (defun stealthily (fn &rest args) > (let ((inhibit-modification-hooks t)) > (apply fn args))) > > (advice-add 'minibuf-eldef-setup-minibuffer :around #'stealthily) That looks like the correct solution for your use case? Anybody else got an opinion here? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no