From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45617: loses the edit region. Works in 23.3, broke in 26.3 Date: Thu, 21 Jan 2021 23:50:32 +0200 Organization: LINKOV.NET Message-ID: <87czxyy5sz.fsf@mail.linkov.net> References: <000001d6e16c$984bcb70$c8e36250$@net> <83turycc18.fsf@gnu.org> <87ble4ob6v.fsf@mail.linkov.net> <000601d6e2ea$8f6601e0$ae3205a0$@net> <877dorkznt.fsf@mail.linkov.net> <002701d6e39b$4ac35680$e04a0380$@net> <8735ze9e09.fsf@mail.linkov.net> <83mtxm0vzd.fsf@gnu.org> <002d01d6e478$ca50cdf0$5ef269d0$@net> <87k0sgirr0.fsf@mail.linkov.net> <002101d6eadc$e816a070$b843e150$@net> <87k0sezj07.fsf@mail.linkov.net> <000c01d6eb68$f3f675f0$dbe361d0$@net> <877do8eull.fsf@mail.linkov.net> <000401d6ef83$32407e50$96c17af0$@net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12102"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 45617@debbugs.gnu.org To: "Bob Floyd" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 22:57:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2hx1-00033b-34 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 22:57:11 +0100 Original-Received: from localhost ([::1]:58474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2hx0-00047A-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 16:57:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2hws-00045F-NR for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2hws-0004be-Fp for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2hws-000395-En for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 16:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45617 X-GNU-PR-Package: emacs Original-Received: via spool by 45617-submit@debbugs.gnu.org id=B45617.161126616212013 (code B ref 45617); Thu, 21 Jan 2021 21:57:02 +0000 Original-Received: (at 45617) by debbugs.gnu.org; 21 Jan 2021 21:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:59591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2hvt-00037Z-No for submit@debbugs.gnu.org; Thu, 21 Jan 2021 16:56:02 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2hvr-00037M-Qr for 45617@debbugs.gnu.org; Thu, 21 Jan 2021 16:56:00 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DE1F440005; Thu, 21 Jan 2021 21:55:52 +0000 (UTC) In-Reply-To: <000401d6ef83$32407e50$96c17af0$@net> (Bob Floyd's message of "Wed, 20 Jan 2021 15:23:00 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198351 Archived-At: > Sorry, sorry, my bad. Ignore my last email! Indeed, in your previous email the function was still messed up, but the right function is below, hope you used it in your test: > I'm now using the last version: > ---------------------------------------------------- > (defun query-replace-read-args (prompt regexp-flag &optional noerror) > (unless noerror > (barf-if-buffer-read-only)) > (save-mark-and-excursion > (let* ((from (query-replace-read-from prompt regexp-flag)) > (to (if (consp from) (prog1 (cdr from) (setq from (car from))) > (query-replace-read-to from prompt regexp-flag)))) > (list from to > (or (and current-prefix-arg (not (eq current-prefix-arg '-))) > (and (plist-member (text-properties-at 0 from) > 'isearch-regexp-function) > (get-text-property 0 'isearch-regexp-function from))) > (and current-prefix-arg (eq current-prefix-arg '-)))))) > ---------------------------------------------------- > Do this: > > 1. Select entire region by dragging left mouse down from the BOTTOM to the > TOP. > 2. Begin > In the command window: Query replace in region: > 3. Double left mouse click on "_iDfnGoverned" at line 4 to select it: > (IObj const& _iDfnGoverned <---THIS ONE , IObj > const& _iBDHparamset) > 4. middle mouse click in the command window to insert, then enter: > Query replace in region: _iDfnGoverned with: > Notice the selection region changes to lines 1-4 and is never restored. > 5. middle mouse click in the command window to insert it again and edit: > Query replace in region _iDfnGoverned with: _iBDHdfnGoverned > 6. Enter > Nothing happens! > > Middle mouse click: mouse-yank-at-click > > Hope you can reproduce this!!! Still can't reproduce this, everything works fine, all matches are replaced. But I don't understand this line: "Notice the selection region changes to lines 1-4 and is never restored." I don't see that the selection region changes to lines 1-4. I see only that the selection region is deactivated after I yank the selection using middle mouse click .