From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#46271: 28.0.50; [PATCH] Properly quote group names for gnus-search Date: Mon, 08 Feb 2021 12:13:38 -0800 Message-ID: <87czxa5nd9.fsf@ericabrahamsen.net> References: <877dnpcm5t.fsf@disroot.org> <875z38zrg4.fsf@ericabrahamsen.net> <87o8gvjyzk.fsf@ericabrahamsen.net> <87pn1as7b6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: jflack@disroot.org, 46271@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 01:17:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9GiZ-0004IV-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 01:17:24 +0100 Original-Received: from localhost ([::1]:40608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9GiY-0005fB-Ti for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 19:17:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Cv4-00027X-M8 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Cv4-000158-AM for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Cv4-0002uO-51 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 15:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46271-submit@debbugs.gnu.org id=B46271.161281523011153 (code B ref 46271); Mon, 08 Feb 2021 20:14:02 +0000 Original-Received: (at 46271) by debbugs.gnu.org; 8 Feb 2021 20:13:50 +0000 Original-Received: from localhost ([127.0.0.1]:51990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Cur-0002tp-Ms for submit@debbugs.gnu.org; Mon, 08 Feb 2021 15:13:49 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:35412 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Cuo-0002ta-Pv for 46271@debbugs.gnu.org; Mon, 08 Feb 2021 15:13:49 -0500 Original-Received: from localhost (97-113-53-191.tukw.qwest.net [97.113.53.191]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 016D9FA214; Mon, 8 Feb 2021 20:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1612815220; bh=QVJe1LspWLtMuvXGqu+gajtwjHMbGfZEaThhRhPUM44=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Tjq8rIijgNy2aBL58cJS7/tgOgQmOSipgklGRJlpjOeJoxoEJp3nthnSkGww2HnTj W3V3NXxj0qAi3Bg+AvcBFLQ9o2nksuQZZiDAuETAfj0wpNvNJPAGV83b3rf2GH5UMS 7aIwtbPwtceiI5Cga1HFH6bza8O0gzr1bxOIUjvA= In-Reply-To: <87pn1as7b6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 08 Feb 2021 19:11:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199643 Archived-At: On 02/08/21 19:11 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> So I think it has to get messier: >> >> (let ((groups '("mail+" "gnus.gener+al" "archive.2007.10"))) >> (mapconcat >> #'identity >> (mapcar >> (lambda (group-name) >> (mapconcat #'regexp-quote >> (split-string >> (gnus-group-real-name group-name) >> "[.\\/]") >> "[.\\\\/]")) >> groups) >> "\\|")) > > AKA: > > (let ((groups '("mail+" "gnus.gener+al" "archive.2007.10"))) > (mapconcat > (lambda (group-name) > (mapconcat #'regexp-quote > (split-string > (gnus-group-real-name group-name) > "[.\\/]") > "[.\\\\/]")) > groups > "\\|")) Ha! That was a brain malfunction. >> Also, I'd prefer not to use rx in this case, simply because this: >> >> "[.\\/]" >> >> turns into this: >> >> (rx (or "\\." "\\\\" "/")) > > Or (rx (in "./\\")), or (rx (in ?. ?/ ?\\)), or... That first one's not bad, but I still don't feel like it's a real improvement over the plain regexp. Anyway, thanks for the tuneup. I think we can just go with this. Eric